giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eli Reisman (JIRA)" <>
Subject [jira] [Commented] (GIRAPH-469) Cleanup GraphMapper
Date Wed, 09 Jan 2013 17:52:12 GMT


Eli Reisman commented on GIRAPH-469:

@nitay we could still add your WorkerThread idea to this as well, I didn't do it yet because
when I was looking at the existing code, it seemed like the MasterThread stuff is encapsulated
well enough, and most of GraphMapper's business logic is really worker code. I figured, why
leave the main thread idle just to spawn another to do the same work the main one does right

Maybe I can tweak these refactors and the new comments/method names to make whats going on
in there even more clear. In existing version, the master/worker roles in the code are certainly
confusing to read, I see your point!

> Cleanup GraphMapper
> -------------------
>                 Key: GIRAPH-469
>                 URL:
>             Project: Giraph
>          Issue Type: Improvement
>            Reporter: Nitay Joffe
>            Assignee: Eli Reisman
>         Attachments: GIRAPH-469-1-eli-idea.patch, GIRAPH-469-2.patch
> I don't see why we even call a map() method seeing as we are overriding run(). We are
clearly not particularly "mapreduce-y" so we should make it our entry point more clear than
a map(). Also I think we should have something like a WorkerThread similar to MasterThread
and clean up all of this to just creare whichever threads the node is assigned roles of. 

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

View raw message