giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maja Kabiljo (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GIRAPH-465) Cleanup MapFunctions
Date Fri, 04 Jan 2013 00:58:13 GMT

    [ https://issues.apache.org/jira/browse/GIRAPH-465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13543478#comment-13543478
] 

Maja Kabiljo commented on GIRAPH-465:
-------------------------------------

Nice refactor, +1. 

I wonder now whether zooKeeperCleanup does what we want, don't we want it to be:
if (isZooKeeper()) ...
                
> Cleanup MapFunctions
> --------------------
>
>                 Key: GIRAPH-465
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-465
>             Project: Giraph
>          Issue Type: Improvement
>            Reporter: Nitay Joffe
>            Assignee: Nitay Joffe
>              Labels: easy, trivial
>         Attachments: GIRAPH-465.patch
>
>
> MapFunctions is a very simple enum and the code using it is convoluted. Instead we can
use some java magic making the enum smarter and cleanup the code that uses it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message