giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eli Reisman (JIRA)" <>
Subject [jira] [Commented] (GIRAPH-299) Constant value in BspServiceMaster should be static
Date Thu, 17 Jan 2013 01:24:23 GMT


Eli Reisman commented on GIRAPH-299:

I tried to build this patch against trunk and got some test errors. Can you try again, making
sure you're patching this in against a clean trunk and see what happens? try plain old 'mvn
clean verify' you might see an error with the accumulo contrib build, but the Giraph-Core
section should list at the end as a "SUCCESS" with no checkstyle (etc.) problems, then you
know its good to go. Thanks again!
> Constant value in BspServiceMaster should be static
> ---------------------------------------------------
>                 Key: GIRAPH-299
>                 URL:
>             Project: Giraph
>          Issue Type: Improvement
>          Components: graph
>    Affects Versions: 0.2.0
>            Reporter: Eli Reisman
>            Priority: Trivial
>              Labels: newbie
>             Fix For: 0.2.0
>         Attachments: GIRAPH-299-2.patch, GIRAPH-299.patch
> GIRAPH-275 was a victim of this weekend's outage of the JIRA site. When I rebased the
patch, I did it from a version that was not the last one I uploaded before said outage. 
> When I rebased the patch today, my most current version was not available to work from.
So I forgot to perform the last fix it needed: to take the "localityLimit" constant on line
138 (used on line 536) of and make it static, and to change the name
to LOCALITY_LIMIT to match proper convention.
> For those that already know how to create and upload a patch, please let this wait, its
a perfect chance for someone new to submitting patches (and to Giraph) to test drive the process.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

View raw message