giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nitay Joffe" <ni...@apache.org>
Subject Re: Review Request: Refactor GraphMapper
Date Thu, 17 Jan 2013 22:42:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8898/#review15471
-----------------------------------------------------------


Sweet, this looks great to me. Just to double check this is purely a refactor, no logic change?


giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java
<https://reviews.apache.org/r/8898/#comment33393>

    nit: call getenv once, put in variable.


- Nitay Joffe


On Jan. 14, 2013, 11:30 p.m., Eli Reisman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8898/
> -----------------------------------------------------------
> 
> (Updated Jan. 14, 2013, 11:30 p.m.)
> 
> 
> Review request for giraph.
> 
> 
> Description
> -------
> 
> Longer description available at the JIRA site. Short version: cleans up and refactors
GraphMapper. Begins a multistage process of setting up the underlying cluster framework (MRv1,
MRv2 + YARN, pure YARN, other cluster management platform...) to be decoupled from Giraph's
BSP business logic. After this patch, the main connection to Hadoop left in the processing
code is the Mapper#Context, and the various references it publishes into Giraph from Hadoop.
Later JIRAs will include more interfaces and a cleaner decoupling. Again, see the JIRA for
more details. Thanks!
> 
> 
> Diffs
> -----
> 
>   giraph-core/src/main/java/org/apache/giraph/bsp/BspService.java 5c44030 
>   giraph-core/src/main/java/org/apache/giraph/bsp/CentralizedServiceWorker.java 56a8288

>   giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java df7b80e 
>   giraph-core/src/main/java/org/apache/giraph/graph/ComputeCallable.java 3292517 
>   giraph-core/src/main/java/org/apache/giraph/graph/GraphFunctions.java PRE-CREATION

>   giraph-core/src/main/java/org/apache/giraph/graph/GraphMapper.java dd4dee4 
>   giraph-core/src/main/java/org/apache/giraph/graph/GraphState.java ee9e6a8 
>   giraph-core/src/main/java/org/apache/giraph/graph/GraphTaskManager.java PRE-CREATION

>   giraph-core/src/main/java/org/apache/giraph/graph/MapFunctions.java f5909d3 
>   giraph-core/src/main/java/org/apache/giraph/master/BspServiceMaster.java 33f9f4a 
>   giraph-core/src/main/java/org/apache/giraph/master/MasterCompute.java cdb9e85 
>   giraph-core/src/main/java/org/apache/giraph/metrics/AggregatedMetrics.java 6052fd8

>   giraph-core/src/main/java/org/apache/giraph/metrics/WorkerSuperstepMetrics.java 8fec14d

>   giraph-core/src/main/java/org/apache/giraph/vertex/Vertex.java d1fbe14 
>   giraph-core/src/main/java/org/apache/giraph/worker/BspServiceWorker.java 31a4dc6 
>   giraph-core/src/main/java/org/apache/giraph/worker/InputSplitsCallable.java acd4e2d

> 
> Diff: https://reviews.apache.org/r/8898/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Eli Reisman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message