giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eli Reisman" <initialcont...@gmail.com>
Subject Review Request: Refactor ZooKeeperManager to prepare for "Pure YARN" implementation of Giraph
Date Tue, 15 Jan 2013 00:11:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8948/
-----------------------------------------------------------

Review request for giraph.


Description
-------

Refactor the ZooKeeperManager so that the instance of the manager is created by a factory.
This allows us to select and implant in the manager at instantiation time a separate object
that encapsulates lifecycle management of a job-local GIraph ZooKeeper. This allows us to
produce a zookeeper instance in the current way (directly using Java's ProcessBuilder) to
be compatible with Hadoop MRv1 and MRv2 on YARN, but also in the future to produce implementations
that generate "pure YARN" ZK application instances, or whatever other underlying cluster management
platforms Giraph will eventually run on. This change only affects jobs that do not use an
existing quorum via giraph.zkList.


Diffs
-----

  giraph-core/src/main/java/org/apache/giraph/graph/GraphMapper.java dd4dee4 
  giraph-core/src/main/java/org/apache/giraph/zk/HadoopZooKeeperProcessBuilder.java PRE-CREATION

  giraph-core/src/main/java/org/apache/giraph/zk/ZooKeeperManager.java 611a4bb 
  giraph-core/src/main/java/org/apache/giraph/zk/ZooKeeperManagerFactory.java PRE-CREATION

  giraph-core/src/main/java/org/apache/giraph/zk/ZooKeeperProcessBuilder.java PRE-CREATION


Diff: https://reviews.apache.org/r/8948/diff/


Testing
-------


Thanks,

Eli Reisman


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message