Return-Path: X-Original-To: apmail-giraph-dev-archive@www.apache.org Delivered-To: apmail-giraph-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 654C1D417 for ; Fri, 7 Dec 2012 21:19:38 +0000 (UTC) Received: (qmail 49637 invoked by uid 500); 7 Dec 2012 21:19:38 -0000 Delivered-To: apmail-giraph-dev-archive@giraph.apache.org Received: (qmail 49595 invoked by uid 500); 7 Dec 2012 21:19:38 -0000 Mailing-List: contact dev-help@giraph.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@giraph.apache.org Delivered-To: mailing list dev@giraph.apache.org Received: (qmail 49584 invoked by uid 99); 7 Dec 2012 21:19:38 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 07 Dec 2012 21:19:38 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id B5F291C53B1; Fri, 7 Dec 2012 21:19:33 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1474305033286815039==" MIME-Version: 1.0 Subject: Re: Review Request: GIRAPH-446: Add a proper timeout for waiting for workers to join a superstep From: "Avery Ching" To: "Avery Ching" , "Maja Kabiljo" , "giraph" Date: Fri, 07 Dec 2012 21:19:33 -0000 Message-ID: <20121207211933.19218.42147@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Avery Ching" X-ReviewGroup: giraph X-ReviewRequest-URL: https://reviews.apache.org/r/8417/ X-Sender: "Avery Ching" References: <20121207190413.19218.14653@reviews.apache.org> In-Reply-To: <20121207190413.19218.14653@reviews.apache.org> Reply-To: "Avery Ching" --===============1474305033286815039== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8417/ ----------------------------------------------------------- (Updated Dec. 7, 2012, 9:19 p.m.) Review request for giraph. Changes ------- Addressed Maja's comments. Description ------- Added a 10 minute default for waiting for workers to join a superstep. This addresses bug GIRAPH-446. https://issues.apache.org/jira/browse/GIRAPH-446 Diffs (updated) ----- http://svn.apache.org/repos/asf/giraph/trunk/giraph/src/main/java/org/apa= che/giraph/GiraphConfiguration.java 1417641 = http://svn.apache.org/repos/asf/giraph/trunk/giraph/src/main/java/org/apa= che/giraph/graph/BspServiceMaster.java 1417641 = http://svn.apache.org/repos/asf/giraph/trunk/giraph/src/main/java/org/apa= che/giraph/graph/BspServiceWorker.java 1417641 = http://svn.apache.org/repos/asf/giraph/trunk/giraph/src/test/java/org/apa= che/giraph/BspCase.java 1417641 = http://svn.apache.org/repos/asf/giraph/trunk/giraph/src/test/java/org/apa= che/giraph/TestAutoCheckpoint.java 1417641 = http://svn.apache.org/repos/asf/giraph/trunk/giraph/src/test/java/org/apa= che/giraph/TestNotEnoughMapTasks.java 1417641 = Diff: https://reviews.apache.org/r/8417/diff/ Testing ------- Passed unittests. Ran on a cluster and saw observed the behavior working c= orrectly. Thanks, Avery Ching --===============1474305033286815039==--