Return-Path: X-Original-To: apmail-giraph-dev-archive@www.apache.org Delivered-To: apmail-giraph-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 26212ECB1 for ; Fri, 7 Dec 2012 17:11:00 +0000 (UTC) Received: (qmail 78226 invoked by uid 500); 7 Dec 2012 17:11:00 -0000 Delivered-To: apmail-giraph-dev-archive@giraph.apache.org Received: (qmail 78176 invoked by uid 500); 7 Dec 2012 17:10:59 -0000 Mailing-List: contact dev-help@giraph.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@giraph.apache.org Delivered-To: mailing list dev@giraph.apache.org Received: (qmail 78161 invoked by uid 99); 7 Dec 2012 17:10:59 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 07 Dec 2012 17:10:59 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id BE79D1C5365; Fri, 7 Dec 2012 17:10:54 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4605474795884625278==" MIME-Version: 1.0 Subject: Review Request: Max message request size in bytes, initialize buffers to expected size From: "Maja Kabiljo" To: "Maja Kabiljo" , "giraph" Date: Fri, 07 Dec 2012 17:10:54 -0000 Message-ID: <20121207171054.19218.32665@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Maja Kabiljo" X-ReviewGroup: giraph X-ReviewRequest-URL: https://reviews.apache.org/r/8407/ X-Sender: "Maja Kabiljo" Reply-To: "Maja Kabiljo" --===============4605474795884625278== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8407/ ----------------------------------------------------------- Review request for giraph. Description ------- Now that all message requests are kept in serialized format, we can limit t= he size of request by the number of bytes, instead of number of messages in= it. Sizing the message buffers to expected size gave about 10% speedup on = a large application run. This addresses bug GIRAPH-445. https://issues.apache.org/jira/browse/GIRAPH-445 Diffs ----- http://svn.apache.org/repos/asf/giraph/trunk/giraph/src/main/java/org/apa= che/giraph/GiraphConfiguration.java 1417645 = http://svn.apache.org/repos/asf/giraph/trunk/giraph/src/main/java/org/apa= che/giraph/comm/SendMessageCache.java 1417645 = http://svn.apache.org/repos/asf/giraph/trunk/giraph/src/main/java/org/apa= che/giraph/comm/netty/NettyWorkerClientRequestProcessor.java 1417645 = Diff: https://reviews.apache.org/r/8407/diff/ Testing ------- mvn verify Large application run on a cluster Thanks, Maja Kabiljo --===============4605474795884625278==--