giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nitay Joffe (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (GIRAPH-444) Cleanup VertexResolver
Date Thu, 06 Dec 2012 20:01:09 GMT

     [ https://issues.apache.org/jira/browse/GIRAPH-444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Nitay Joffe updated GIRAPH-444:
-------------------------------

    Description: 
Few minor but necessary touchups to VertexResolver:

1) We're using VertexResolver in a bunch of places when we should be using BasicVertexResolver
(the interface). On that note seems to me these two names should be flipped, that is VertexResolver
should be the interface and BasicVertexResolver the default implementation. Thoughts?
2) Add GraphStateConfigurable interface similar to Configurable.
3) Add a boolean option for user to control whether to create vertex for a vertex that didn't
exist but got messages. Need this for an algorithm I'm working on and seems to me to be general
enough of a decision that we should allow user to control it.
4) General cleanup of VertexResolver logic into separate functions (no logic change).

https://reviews.apache.org/r/8370/

  was:
Few minor but necessary touchups to VertexResolver:

1) We're using VertexResolver in a bunch of places when we should be using BasicVertexResolver
(the interface). On that note seems to me these two names should be flipped, that is VertexResolver
should be the interface and BasicVertexResolver the default implementation. Thoughts?
2) Add GraphStateConfigurable interface similar to Configurable.
3) Add a boolean option for user to control whether to create vertex for a vertex that didn't
exist but got messages. Need this for an algorithm I'm working on and seems to me to be general
enough of a decision that we should allow user to control it.
4) General cleanup of VertexResolver logic into separate functions (no logic change).

    
> Cleanup VertexResolver
> ----------------------
>
>                 Key: GIRAPH-444
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-444
>             Project: Giraph
>          Issue Type: Bug
>            Reporter: Nitay Joffe
>            Assignee: Nitay Joffe
>            Priority: Minor
>              Labels: easy
>         Attachments: GIRAPH-444.patch
>
>
> Few minor but necessary touchups to VertexResolver:
> 1) We're using VertexResolver in a bunch of places when we should be using BasicVertexResolver
(the interface). On that note seems to me these two names should be flipped, that is VertexResolver
should be the interface and BasicVertexResolver the default implementation. Thoughts?
> 2) Add GraphStateConfigurable interface similar to Configurable.
> 3) Add a boolean option for user to control whether to create vertex for a vertex that
didn't exist but got messages. Need this for an algorithm I'm working on and seems to me to
be general enough of a decision that we should allow user to control it.
> 4) General cleanup of VertexResolver logic into separate functions (no logic change).
> https://reviews.apache.org/r/8370/

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message