giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maja Kabiljo" <majakabi...@fb.com>
Subject Re: Review Request: Max message request size in bytes, initialize buffers to expected size
Date Mon, 10 Dec 2012 18:07:56 GMT


> On Dec. 9, 2012, 9:31 a.m., Avery Ching wrote:
> > +1.  This looks pretty good Maja.  Just a few minor things belows.

Thanks for the review!


- Maja


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8407/#review14208
-----------------------------------------------------------


On Dec. 10, 2012, 6:07 p.m., Maja Kabiljo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8407/
> -----------------------------------------------------------
> 
> (Updated Dec. 10, 2012, 6:07 p.m.)
> 
> 
> Review request for giraph.
> 
> 
> Description
> -------
> 
> Now that all message requests are kept in serialized format, we can limit the size of
request by the number of bytes, instead of number of messages in it. Sizing the message buffers
to expected size gave about 10% speedup on a large application run.
> 
> 
> This addresses bug GIRAPH-445.
>     https://issues.apache.org/jira/browse/GIRAPH-445
> 
> 
> Diffs
> -----
> 
>   http://svn.apache.org/repos/asf/giraph/trunk/giraph/src/main/java/org/apache/giraph/GiraphConfiguration.java
1419615 
>   http://svn.apache.org/repos/asf/giraph/trunk/giraph/src/main/java/org/apache/giraph/comm/SendMessageCache.java
1419615 
>   http://svn.apache.org/repos/asf/giraph/trunk/giraph/src/main/java/org/apache/giraph/comm/netty/NettyWorkerClientRequestProcessor.java
1419615 
> 
> Diff: https://reviews.apache.org/r/8407/diff/
> 
> 
> Testing
> -------
> 
> mvn verify
> Large application run on a cluster
> 
> 
> Thanks,
> 
> Maja Kabiljo
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message