Return-Path: X-Original-To: apmail-giraph-dev-archive@www.apache.org Delivered-To: apmail-giraph-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id AA461DD9C for ; Thu, 1 Nov 2012 00:29:13 +0000 (UTC) Received: (qmail 90135 invoked by uid 500); 1 Nov 2012 00:29:12 -0000 Delivered-To: apmail-giraph-dev-archive@giraph.apache.org Received: (qmail 90060 invoked by uid 500); 1 Nov 2012 00:29:12 -0000 Mailing-List: contact dev-help@giraph.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@giraph.apache.org Delivered-To: mailing list dev@giraph.apache.org Received: (qmail 89887 invoked by uid 500); 1 Nov 2012 00:29:12 -0000 Delivered-To: apmail-incubator-giraph-dev@incubator.apache.org Received: (qmail 89821 invoked by uid 99); 1 Nov 2012 00:29:12 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Nov 2012 00:29:12 +0000 Date: Thu, 1 Nov 2012 00:29:12 +0000 (UTC) From: "Maja Kabiljo (JIRA)" To: giraph-dev@incubator.apache.org Message-ID: <688874477.53794.1351729752631.JavaMail.jiratomcat@arcas> In-Reply-To: <746172858.53787.1351729632001.JavaMail.jiratomcat@arcas> Subject: [jira] [Updated] (GIRAPH-397) We should have copies of aggregators per thread to avoid synchronizing on aggregate() MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/GIRAPH-397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maja Kabiljo updated GIRAPH-397: -------------------------------- Attachment: GIRAPH-397.patch I added this as an option (default to use it), for one of our applications with huge aggregators we don't want to use it since we don't want to spend that much memory on having a lot of copies of aggregators. Passes verify and AggregatorsBenchmark on cluster. > We should have copies of aggregators per thread to avoid synchronizing on aggregate() > ------------------------------------------------------------------------------------- > > Key: GIRAPH-397 > URL: https://issues.apache.org/jira/browse/GIRAPH-397 > Project: Giraph > Issue Type: Improvement > Reporter: Maja Kabiljo > Assignee: Maja Kabiljo > Priority: Minor > Attachments: GIRAPH-397.patch > > > Fixing one of TODOs from GIRAPH-273. Adding copies of aggregators for each thread allows us not to have to synchronize on each aggregate call. Aggregated values from each thread can be aggregated together after computation is finished. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira