Return-Path: X-Original-To: apmail-giraph-dev-archive@www.apache.org Delivered-To: apmail-giraph-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5BA0DDA14 for ; Fri, 30 Nov 2012 01:30:19 +0000 (UTC) Received: (qmail 36677 invoked by uid 500); 30 Nov 2012 01:30:19 -0000 Delivered-To: apmail-giraph-dev-archive@giraph.apache.org Received: (qmail 36633 invoked by uid 500); 30 Nov 2012 01:30:19 -0000 Mailing-List: contact dev-help@giraph.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@giraph.apache.org Delivered-To: mailing list dev@giraph.apache.org Received: (qmail 36622 invoked by uid 99); 30 Nov 2012 01:30:19 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 30 Nov 2012 01:30:19 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 1F0361C4E72; Fri, 30 Nov 2012 01:30:15 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2110050755201492321==" MIME-Version: 1.0 Subject: Review Request: GIRAPH-438: When checkpointing is disable, fast fail From: "Avery Ching" To: "Avery Ching" , "giraph" Date: Fri, 30 Nov 2012 01:30:15 -0000 Message-ID: <20121130013015.22473.63665@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Avery Ching" X-ReviewGroup: giraph X-ReviewRequest-URL: https://reviews.apache.org/r/8287/ X-Sender: "Avery Ching" Reply-To: "Avery Ching" --===============2110050755201492321== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8287/ ----------------------------------------------------------- Review request for giraph. Description ------- Add a minor check before job submission on the checkpoint frequency and set= max task attempts to 0 if checkpoint frequency is 0. Notifies the user as= well. This addresses bug GIRAPH-438. https://issues.apache.org/jira/browse/GIRAPH-438 Diffs ----- http://svn.apache.org/repos/asf/giraph/trunk/giraph/src/main/java/org/apa= che/giraph/GiraphConfiguration.java 1414463 = http://svn.apache.org/repos/asf/giraph/trunk/giraph/src/main/java/org/apa= che/giraph/benchmark/RandomMessageBenchmark.java 1414463 = http://svn.apache.org/repos/asf/giraph/trunk/giraph/src/main/java/org/apa= che/giraph/graph/BspService.java 1414463 = http://svn.apache.org/repos/asf/giraph/trunk/giraph/src/main/java/org/apa= che/giraph/graph/GiraphJob.java 1414463 = http://svn.apache.org/repos/asf/giraph/trunk/giraph/src/test/java/org/apa= che/giraph/TestAutoCheckpoint.java 1414463 = http://svn.apache.org/repos/asf/giraph/trunk/giraph/src/test/java/org/apa= che/giraph/TestManualCheckpoint.java 1414463 = http://svn.apache.org/repos/asf/giraph/trunk/giraph/src/test/java/org/apa= che/giraph/graph/TestAggregatorsHandling.java 1414463 = Diff: https://reviews.apache.org/r/8287/diff/ Testing ------- mvn clean install Ran a page rank benchmark job to verify the number of attempts goes to 0 wh= en the checkpoint frequency is 0. Thanks, Avery Ching --===============2110050755201492321==--