Return-Path: X-Original-To: apmail-giraph-dev-archive@www.apache.org Delivered-To: apmail-giraph-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id AB958DF83 for ; Sat, 17 Nov 2012 03:42:08 +0000 (UTC) Received: (qmail 94703 invoked by uid 500); 17 Nov 2012 03:42:08 -0000 Delivered-To: apmail-giraph-dev-archive@giraph.apache.org Received: (qmail 94621 invoked by uid 500); 17 Nov 2012 03:42:07 -0000 Mailing-List: contact dev-help@giraph.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@giraph.apache.org Delivered-To: mailing list dev@giraph.apache.org Received: (qmail 94593 invoked by uid 99); 17 Nov 2012 03:42:06 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 17 Nov 2012 03:42:06 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id E48241C010E; Sat, 17 Nov 2012 03:42:02 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8635257979254945421==" MIME-Version: 1.0 Subject: Re: Review Request: GIRAPH-421: Aggregate metrics up to master From: "Nitay Joffe" To: "Maja Kabiljo" , "giraph" , "Nitay Joffe" , "Alessandro Presta" Date: Sat, 17 Nov 2012 03:42:02 -0000 Message-ID: <20121117034202.10524.93046@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Nitay Joffe" X-ReviewGroup: giraph X-ReviewRequest-URL: https://reviews.apache.org/r/8042/ X-Sender: "Nitay Joffe" References: <20121117031703.10524.36871@reviews.apache.org> In-Reply-To: <20121117031703.10524.36871@reviews.apache.org> Reply-To: "Nitay Joffe" --===============8635257979254945421== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8042/ ----------------------------------------------------------- (Updated Nov. 17, 2012, 3:42 a.m.) Review request for giraph. Description (updated) ------- https://issues.apache.org/jira/browse/GIRAPH-421 The workers send their metrics to the master by writing them to the ZK node= that is already used for FinishedSuperstepStats. The master reads each worker's metrics, aggregates, and prints an overall s= ummary. Worker: https://gist.github.com/23edefe0c5bbbfd25f93 Prints a summary at the end of each superstep. At the end of the job it doe= s a raw dump of all of the metrics. = Master: https://gist.github.com/1d45385441ced2470ca9 At end of each superstep it gathers the metrics and computes mean, min, and= max. Anything else we should compute? There is also support for the master to track and print its own metrics, bu= t this is not really used right now. As a part of this diff I also cleaned some things up, namely: - Just one option now to use, called giraph.metrics.enable, which toggles e= verything. When false (default), no work is done. When enabled, every worke= r and the master tracks metrics. They are aggregated and printed as in exam= ples below. - Changed metrics that are often small values like "time to first message" = and "waiting time" to be in microseconds instead of milliseconds. Diffs ----- /trunk/giraph/src/main/java/org/apache/giraph/GiraphConfiguration.java 14= 09973 = /trunk/giraph/src/main/java/org/apache/giraph/graph/BspService.java 14099= 73 = /trunk/giraph/src/main/java/org/apache/giraph/graph/BspServiceMaster.java= 1409973 = /trunk/giraph/src/main/java/org/apache/giraph/graph/BspServiceWorker.java= 1409973 = /trunk/giraph/src/main/java/org/apache/giraph/graph/GraphMapper.java 1409= 973 = /trunk/giraph/src/main/java/org/apache/giraph/metrics/AggregatedMetric.ja= va PRE-CREATION = /trunk/giraph/src/main/java/org/apache/giraph/metrics/AggregatedMetrics.j= ava PRE-CREATION = /trunk/giraph/src/main/java/org/apache/giraph/metrics/GiraphMetrics.java = 1409973 = /trunk/giraph/src/main/java/org/apache/giraph/metrics/GiraphMetricsRegist= ry.java 1409973 = /trunk/giraph/src/main/java/org/apache/giraph/metrics/MetricsRegistryDebu= gger.java PRE-CREATION = /trunk/giraph/src/main/java/org/apache/giraph/metrics/SuperstepMetricsReg= istry.java 1409973 = /trunk/giraph/src/main/java/org/apache/giraph/metrics/ValueWithHostname.j= ava PRE-CREATION = /trunk/giraph/src/main/java/org/apache/giraph/metrics/WorkerSuperstepMetr= ics.java PRE-CREATION = /trunk/giraph/src/main/java/org/apache/giraph/utils/FakeTime.java 1409973 = /trunk/giraph/src/main/java/org/apache/giraph/utils/SystemTime.java 14099= 73 = /trunk/giraph/src/main/java/org/apache/giraph/utils/Time.java 1409973 = /trunk/giraph/src/main/java/org/apache/giraph/utils/Times.java 1409973 = /trunk/giraph/src/main/java/org/apache/giraph/utils/WritableUtils.java 14= 09973 = Diff: https://reviews.apache.org/r/8042/diff/ Testing ------- Thanks, Nitay Joffe --===============8635257979254945421==--