Return-Path: X-Original-To: apmail-giraph-dev-archive@www.apache.org Delivered-To: apmail-giraph-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BF62EDB99 for ; Mon, 12 Nov 2012 10:50:07 +0000 (UTC) Received: (qmail 85927 invoked by uid 500); 12 Nov 2012 10:50:07 -0000 Delivered-To: apmail-giraph-dev-archive@giraph.apache.org Received: (qmail 85867 invoked by uid 500); 12 Nov 2012 10:50:06 -0000 Mailing-List: contact dev-help@giraph.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@giraph.apache.org Delivered-To: mailing list dev@giraph.apache.org Received: (qmail 85841 invoked by uid 99); 12 Nov 2012 10:50:06 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 12 Nov 2012 10:50:06 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id C899B1C0D1B; Mon, 12 Nov 2012 10:50:02 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3688495126862795027==" MIME-Version: 1.0 Subject: Re: Review Request: GIRAPH-415: Refactor / cleanup Hadoop Counters From: "Nitay Joffe" To: "Maja Kabiljo" , "giraph" , "Nitay Joffe" Date: Mon, 12 Nov 2012 10:50:02 -0000 Message-ID: <20121112105002.10524.6446@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Nitay Joffe" X-ReviewGroup: giraph X-ReviewRequest-URL: https://reviews.apache.org/r/7980/ X-Sender: "Nitay Joffe" References: <20121109190304.24842.29707@reviews.apache.org> In-Reply-To: <20121109190304.24842.29707@reviews.apache.org> Reply-To: "Nitay Joffe" --===============3688495126862795027== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On Nov. 9, 2012, 7:03 p.m., Maja Kabiljo wrote: > > giraph/src/main/java/org/apache/giraph/counters/GiraphStats.java, line = 170 > > > > > > Am I missing something or this is not used? = > > I understand the idea of it being Iterable, but why don't make Hado= opCountersBase Iterable then? It's to make it easier for users. Done, made HadoopCounterBase Iterable. > On Nov. 9, 2012, 7:03 p.m., Maja Kabiljo wrote: > > giraph/src/main/java/org/apache/giraph/graph/BspServiceMaster.java, lin= e 769 > > > > > > You can use setValue here That makes the logic different than before though? I mean it was using incr= ement() before too, so this have a different effect? - Nitay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7980/#review13296 ----------------------------------------------------------- On Nov. 9, 2012, 12:07 a.m., Nitay Joffe wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7980/ > ----------------------------------------------------------- > = > (Updated Nov. 9, 2012, 12:07 a.m.) > = > = > Review request for giraph. > = > = > Description > ------- > = > GIRAPH-415: Refactor / cleanup Hadoop Counters > = > = > Diffs > ----- > = > giraph/src/main/java/org/apache/giraph/counters/GiraphHadoopCounter.jav= a PRE-CREATION = > giraph/src/main/java/org/apache/giraph/counters/GiraphStats.java PRE-CR= EATION = > giraph/src/main/java/org/apache/giraph/counters/GiraphTimers.java PRE-C= REATION = > giraph/src/main/java/org/apache/giraph/counters/HadoopCountersBase.java= PRE-CREATION = > giraph/src/main/java/org/apache/giraph/counters/package-info.java PRE-C= REATION = > giraph/src/main/java/org/apache/giraph/graph/BspServiceMaster.java 7d5d= abb9df619b82dd42ab631b3c244fbdd9ddcf = > giraph/src/main/java/org/apache/giraph/graph/EdgeListVertex.java 8801dd= e5102ffca397678b0dcc3dd7c2932d22d7 = > giraph/src/main/java/org/apache/giraph/graph/HashMapVertex.java 26b14ca= ed23706b12f21142862bbd15fe3720bd6 = > giraph/src/main/java/org/apache/giraph/graph/IntIntNullIntVertex.java a= 23b87f7e43d6a3b78516cbb5f1dd512dca84a8d = > giraph/src/main/java/org/apache/giraph/graph/LongDoubleFloatDoubleVerte= x.java 1db6e977eb4a8102351a908dc1a113935002e61e = > giraph/src/main/java/org/apache/giraph/graph/MasterThread.java 5c9a72d5= edbaafddca1f5050131a1657e15f5ac2 = > giraph/src/main/java/org/apache/giraph/graph/SimpleMutableVertex.java 8= 5af9700e76a3ef32191fe0dc5631f430b13de42 = > giraph/src/main/java/org/apache/giraph/graph/SimpleVertex.java ed6759a8= 84553fa15ee477e19e483e1d210ba7be = > giraph/src/main/java/org/apache/giraph/graph/Vertex.java 8789ee5c8f170b= 6d598f0b36053333b1f6f36227 = > giraph/src/main/java/org/apache/giraph/metrics/EmptyMetricsRegistry.jav= a 262db29bbd4797e470f426999b85f2c1a7d1dee3 = > giraph/src/main/java/org/apache/giraph/metrics/GiraphMetricsRegistry.ja= va eac9f7295d968c3b30c40b89944e8f9f8549cc70 = > giraph/src/main/java/org/apache/giraph/metrics/NoOpMetricsRegistry.java= PRE-CREATION = > giraph/src/main/java/org/apache/giraph/metrics/package-info.java f7529f= 52527e8e4253f579bd6d01865aa980926b = > = > Diff: https://reviews.apache.org/r/7980/diff/ > = > = > Testing > ------- > = > = > Thanks, > = > Nitay Joffe > = > --===============3688495126862795027==--