Return-Path: X-Original-To: apmail-giraph-dev-archive@www.apache.org Delivered-To: apmail-giraph-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 698B6DC7C for ; Fri, 9 Nov 2012 05:52:13 +0000 (UTC) Received: (qmail 94723 invoked by uid 500); 9 Nov 2012 05:52:12 -0000 Delivered-To: apmail-giraph-dev-archive@giraph.apache.org Received: (qmail 94673 invoked by uid 500); 9 Nov 2012 05:52:11 -0000 Mailing-List: contact dev-help@giraph.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@giraph.apache.org Delivered-To: mailing list dev@giraph.apache.org Received: (qmail 94630 invoked by uid 99); 9 Nov 2012 05:52:10 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 09 Nov 2012 05:52:10 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 2A5781C4383; Fri, 9 Nov 2012 05:52:05 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1827690448765686056==" MIME-Version: 1.0 Subject: Re: Review Request: GIRAPH-416: MasterObserver for user post-application customization From: "Avery Ching" To: "Avery Ching" , "giraph" , "Nitay Joffe" Date: Fri, 09 Nov 2012 05:52:05 -0000 Message-ID: <20121109055205.24874.71939@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Avery Ching" X-ReviewGroup: giraph X-ReviewRequest-URL: https://reviews.apache.org/r/7981/ X-Sender: "Avery Ching" References: <20121109030954.4790.53681@reviews.apache.org> In-Reply-To: <20121109030954.4790.53681@reviews.apache.org> Reply-To: "Avery Ching" --===============1827690448765686056== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7981/#review13284 ----------------------------------------------------------- This looks pretty good. One comment below though. giraph/src/main/java/org/apache/giraph/ImmutableClassesGiraphConfiguration.= java These methods could be in GiraphConfiguration. Methods in ImmmutableCl= assesGiraphConfiguration should be for immutable variables (i.e. private fi= nal and assigned from the constructor) and for fast acesss. - Avery Ching On Nov. 9, 2012, 3:09 a.m., Nitay Joffe wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7981/ > ----------------------------------------------------------- > = > (Updated Nov. 9, 2012, 3:09 a.m.) > = > = > Review request for giraph. > = > = > Description > ------- > = > GIRAPH-416: MasterObserver for user post-application customization > = > = > Diffs > ----- > = > giraph/src/main/java/org/apache/giraph/GiraphConfiguration.java 496bce7 = > giraph/src/main/java/org/apache/giraph/ImmutableClassesGiraphConfigurat= ion.java bb6a739 = > giraph/src/main/java/org/apache/giraph/bsp/CentralizedServiceMaster.jav= a 688ce43 = > giraph/src/main/java/org/apache/giraph/graph/BspServiceMaster.java 7d5d= abb = > giraph/src/main/java/org/apache/giraph/graph/IntNullNullNullVertex.java= PRE-CREATION = > giraph/src/main/java/org/apache/giraph/graph/MasterThread.java 5c9a72d = > giraph/src/main/java/org/apache/giraph/io/IntNullNullNullTextInputForma= t.java PRE-CREATION = > giraph/src/main/java/org/apache/giraph/master/DefaultMasterObserver.jav= a PRE-CREATION = > giraph/src/main/java/org/apache/giraph/master/MasterObserver.java PRE-C= REATION = > giraph/src/main/java/org/apache/giraph/master/package-info.java PRE-CRE= ATION = > giraph/src/main/java/org/apache/giraph/utils/InternalVertexRunner.java = b891690 = > giraph/src/test/java/org/apache/giraph/TestGiraphConfiguration.java PRE= -CREATION = > giraph/src/test/java/org/apache/giraph/TestMasterObserver.java PRE-CREA= TION = > = > Diff: https://reviews.apache.org/r/7981/diff/ > = > = > Testing > ------- > = > = > Thanks, > = > Nitay Joffe > = > --===============1827690448765686056==--