Return-Path: X-Original-To: apmail-giraph-dev-archive@www.apache.org Delivered-To: apmail-giraph-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D512FDBCE for ; Fri, 2 Nov 2012 21:30:19 +0000 (UTC) Received: (qmail 6872 invoked by uid 500); 2 Nov 2012 21:30:19 -0000 Delivered-To: apmail-giraph-dev-archive@giraph.apache.org Received: (qmail 6811 invoked by uid 500); 2 Nov 2012 21:30:19 -0000 Mailing-List: contact dev-help@giraph.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@giraph.apache.org Delivered-To: mailing list dev@giraph.apache.org Received: (qmail 6800 invoked by uid 99); 2 Nov 2012 21:30:19 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Nov 2012 21:30:19 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id B4F591C455A; Fri, 2 Nov 2012 21:30:16 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6026345965957329990==" MIME-Version: 1.0 Subject: Re: Review Request: Allow creation of graph by adding edges that span multiple workers From: "Avery Ching" To: "Avery Ching" , "giraph" , "Alessandro Presta" Date: Fri, 02 Nov 2012 21:30:16 -0000 Message-ID: <20121102213016.9681.55534@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Avery Ching" X-ReviewGroup: giraph X-ReviewRequest-URL: https://reviews.apache.org/r/7784/ X-Sender: "Avery Ching" References: <20121102212801.9681.16611@reviews.apache.org> In-Reply-To: <20121102212801.9681.16611@reviews.apache.org> Reply-To: "Avery Ching" --===============6026345965957329990== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7784/#review13064 ----------------------------------------------------------- Ship it! Ship It! - Avery Ching On Nov. 2, 2012, 9:28 p.m., Alessandro Presta wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7784/ > ----------------------------------------------------------- > = > (Updated Nov. 2, 2012, 9:28 p.m.) > = > = > Review request for giraph. > = > = > Description > ------- > = > Allow creation of graph by adding edges that span multiple workers > = > = > This addresses bug GIRAPH-155. > https://issues.apache.org/jira/browse/GIRAPH-155 > = > = > Diffs > ----- > = > /trunk/giraph/src/main/java/org/apache/giraph/GiraphConfiguration.java = 1404751 = > /trunk/giraph/src/main/java/org/apache/giraph/ImmutableClassesGiraphCon= figuration.java 1404751 = > /trunk/giraph/src/main/java/org/apache/giraph/bsp/CentralizedServiceMas= ter.java 1404751 = > /trunk/giraph/src/main/java/org/apache/giraph/comm/WorkerServer.java 14= 04751 = > /trunk/giraph/src/main/java/org/apache/giraph/comm/netty/NettyWorkerCli= entRequestProcessor.java 1404751 = > /trunk/giraph/src/main/java/org/apache/giraph/comm/netty/NettyWorkerSer= ver.java 1404751 = > /trunk/giraph/src/main/java/org/apache/giraph/comm/requests/SendPartiti= onMutationsRequest.java 1404751 = > /trunk/giraph/src/main/java/org/apache/giraph/graph/BasicVertexValueRea= der.java PRE-CREATION = > /trunk/giraph/src/main/java/org/apache/giraph/graph/BspService.java 140= 4751 = > /trunk/giraph/src/main/java/org/apache/giraph/graph/BspServiceMaster.ja= va 1404751 = > /trunk/giraph/src/main/java/org/apache/giraph/graph/BspServiceWorker.ja= va 1404751 = > /trunk/giraph/src/main/java/org/apache/giraph/graph/BspUtils.java 14047= 51 = > /trunk/giraph/src/main/java/org/apache/giraph/graph/EdgeInputFormat.jav= a PRE-CREATION = > /trunk/giraph/src/main/java/org/apache/giraph/graph/EdgeInputSplitsCall= able.java PRE-CREATION = > /trunk/giraph/src/main/java/org/apache/giraph/graph/EdgeInputSplitsCall= ableFactory.java PRE-CREATION = > /trunk/giraph/src/main/java/org/apache/giraph/graph/EdgeReader.java PRE= -CREATION = > /trunk/giraph/src/main/java/org/apache/giraph/graph/EdgeWithSource.java= PRE-CREATION = > /trunk/giraph/src/main/java/org/apache/giraph/graph/GiraphInputFormat.j= ava PRE-CREATION = > /trunk/giraph/src/main/java/org/apache/giraph/graph/GiraphJob.java 1404= 751 = > /trunk/giraph/src/main/java/org/apache/giraph/graph/GraphMapper.java 14= 04751 = > /trunk/giraph/src/main/java/org/apache/giraph/graph/InputSplitEvents.ja= va PRE-CREATION = > /trunk/giraph/src/main/java/org/apache/giraph/graph/InputSplitPaths.jav= a PRE-CREATION = > /trunk/giraph/src/main/java/org/apache/giraph/graph/InputSplitsCallable= .java 1404751 = > /trunk/giraph/src/main/java/org/apache/giraph/graph/InputSplitsCallable= Factory.java PRE-CREATION = > /trunk/giraph/src/main/java/org/apache/giraph/graph/MasterThread.java 1= 404751 = > /trunk/giraph/src/main/java/org/apache/giraph/graph/VertexInputFormat.j= ava 1404751 = > /trunk/giraph/src/main/java/org/apache/giraph/graph/VertexInputSplitsCa= llable.java PRE-CREATION = > /trunk/giraph/src/main/java/org/apache/giraph/graph/VertexInputSplitsCa= llableFactory.java PRE-CREATION = > /trunk/giraph/src/main/java/org/apache/giraph/graph/VertexReader.java 1= 404751 = > /trunk/giraph/src/main/java/org/apache/giraph/graph/VertexResolver.java= 1404751 = > /trunk/giraph/src/main/java/org/apache/giraph/graph/VertexValueInputFor= mat.java PRE-CREATION = > /trunk/giraph/src/main/java/org/apache/giraph/graph/VertexValueReader.j= ava PRE-CREATION = > /trunk/giraph/src/main/java/org/apache/giraph/io/GiraphFileInputFormat.= java PRE-CREATION = > /trunk/giraph/src/main/java/org/apache/giraph/io/GiraphTextInputFormat.= java PRE-CREATION = > /trunk/giraph/src/main/java/org/apache/giraph/io/IntIntTextVertexValueI= nputFormat.java PRE-CREATION = > /trunk/giraph/src/main/java/org/apache/giraph/io/IntNullTextEdgeInputFo= rmat.java PRE-CREATION = > /trunk/giraph/src/main/java/org/apache/giraph/io/TextEdgeInputFormat.ja= va PRE-CREATION = > /trunk/giraph/src/main/java/org/apache/giraph/io/TextVertexInputFormat.= java 1404751 = > /trunk/giraph/src/main/java/org/apache/giraph/io/TextVertexValueInputFo= rmat.java PRE-CREATION = > /trunk/giraph/src/main/java/org/apache/giraph/utils/FileUtils.java 1404= 751 = > /trunk/giraph/src/main/java/org/apache/giraph/utils/IntPair.java PRE-CR= EATION = > /trunk/giraph/src/main/java/org/apache/giraph/utils/InternalVertexRunne= r.java 1404751 = > /trunk/giraph/src/test/java/org/apache/giraph/BspCase.java 1404751 = > /trunk/giraph/src/test/java/org/apache/giraph/TestEdgeInput.java PRE-CR= EATION = > /trunk/giraph/src/test/java/org/apache/giraph/TestJsonBase64Format.java= 1404751 = > /trunk/giraph/src/test/java/org/apache/giraph/io/TestTextDoubleDoubleAd= jacencyListVertexInputFormat.java 1404751 = > = > Diff: https://reviews.apache.org/r/7784/diff/ > = > = > Testing > ------- > = > 1) mvn verify > 2) pseudo-distributed tests > 3) PageRank on cluster with real text input (will post perf results on th= e issue) > = > = > Thanks, > = > Alessandro Presta > = > --===============6026345965957329990==--