giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eli Reisman (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GIRAPH-413) Make building Facebook profile easier
Date Sun, 11 Nov 2012 21:33:12 GMT

    [ https://issues.apache.org/jira/browse/GIRAPH-413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13495001#comment-13495001
] 

Eli Reisman commented on GIRAPH-413:
------------------------------------

I have always liked the idea of -P being the single point of reference for selecting a profile
to run rather than -D getting involved too.
                
> Make building Facebook profile easier
> -------------------------------------
>
>                 Key: GIRAPH-413
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-413
>             Project: Giraph
>          Issue Type: Improvement
>            Reporter: Nitay Joffe
>            Assignee: Nitay Joffe
>         Attachments: GIRAPH-413-2.patch, GIRAPH-413.patch, hadoop-0.20-core.jar
>
>
> Until Facebook publishes jars for it's open sourced version of Hadoop to some maven repositories,
we can just include the built jar in our 
> codebase directly. This removes the need for the whole -Dhadoop.jar.path whatnot and
lowers the barrier for using this profile.
> Also now the following works:
> >> dev-support/for-each-profile.sh clean install
> Rebuilds current codebase on every profile. Some profiles are still failing in formats
because they don't work with the given hadoop version, but the script now functions.
> I also removed the -Dhadoop=xx option for profile activation. Is there a reason for having
this instead of just having everyone consistently use -Phadoop_xx?
> https://reviews.apache.org/r/7924/

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message