giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maja Kabiljo" <majakabi...@fb.com>
Subject Re: Review Request: GIRAPH-437: Missing progress calls when stopping Netty server
Date Fri, 30 Nov 2012 18:17:54 GMT


> On Nov. 30, 2012, 1:15 a.m., Avery Ching wrote:
> > +1, looks good to me.  I like the Waitable interface.

Thanks for the review, Avery!


- Maja


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8286/#review13885
-----------------------------------------------------------


On Nov. 29, 2012, 11:59 p.m., Maja Kabiljo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8286/
> -----------------------------------------------------------
> 
> (Updated Nov. 29, 2012, 11:59 p.m.)
> 
> 
> Review request for giraph.
> 
> 
> Description
> -------
> 
> At the end of a long running job I got an exception about not reporting progress. The
last log line was: "stop: Halting netty server", so I suspect it's because awaitUninterruptibly()
call there.
> 
> Changing awaitUninterruptibly to periodical calls of await. Added a log line to the end
of NettyServer.stop so if it happens again we can be sure where the problem is. I also refactored
ProgressableUtils so new cases where we need to wait for something will be easier to write.
> 
> 
> This addresses bug GIRAPH-437.
>     https://issues.apache.org/jira/browse/GIRAPH-437
> 
> 
> Diffs
> -----
> 
>   http://svn.apache.org/repos/asf/giraph/trunk/giraph/src/main/java/org/apache/giraph/comm/netty/NettyMasterServer.java
1415035 
>   http://svn.apache.org/repos/asf/giraph/trunk/giraph/src/main/java/org/apache/giraph/comm/netty/NettyServer.java
1415035 
>   http://svn.apache.org/repos/asf/giraph/trunk/giraph/src/main/java/org/apache/giraph/comm/netty/NettyWorkerServer.java
1415035 
>   http://svn.apache.org/repos/asf/giraph/trunk/giraph/src/main/java/org/apache/giraph/graph/BspServiceMaster.java
1415035 
>   http://svn.apache.org/repos/asf/giraph/trunk/giraph/src/main/java/org/apache/giraph/utils/ProgressableUtils.java
1415035 
>   http://svn.apache.org/repos/asf/giraph/trunk/giraph/src/test/java/org/apache/giraph/comm/ConnectionTest.java
1415035 
>   http://svn.apache.org/repos/asf/giraph/trunk/giraph/src/test/java/org/apache/giraph/comm/RequestFailureTest.java
1415035 
>   http://svn.apache.org/repos/asf/giraph/trunk/giraph/src/test/java/org/apache/giraph/comm/RequestTest.java
1415035 
>   http://svn.apache.org/repos/asf/giraph/trunk/giraph/src/test/java/org/apache/giraph/comm/SaslConnectionTest.java
1415035 
> 
> Diff: https://reviews.apache.org/r/8286/diff/
> 
> 
> Testing
> -------
> 
> mvn verify
> 
> 
> Thanks,
> 
> Maja Kabiljo
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message