giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Avery Ching" <avery.ch...@gmail.com>
Subject Re: Review Request: Edge-based input from HCatalog
Date Mon, 19 Nov 2012 23:08:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8034/#review13580
-----------------------------------------------------------


Couple of extra comments above Nitay's.  Looks good though.


/trunk/giraph-formats-contrib/src/main/java/org/apache/giraph/io/hcatalog/GiraphHCatInputFormat.java
<https://reviews.apache.org/r/8034/#comment29144>

    Perhaps remove (malewicz)?



/trunk/giraph-formats-contrib/src/main/java/org/apache/hcatalog/mapreduce/HCatUtils.java
<https://reviews.apache.org/r/8034/#comment29170>

    missing space



/trunk/pom.xml
<https://reviews.apache.org/r/8034/#comment29143>

    Just to verify, this doesn't include the hive jars in giraph, only the giraph-contrib-formats?


- Avery Ching


On Nov. 19, 2012, 10:28 p.m., Alessandro Presta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8034/
> -----------------------------------------------------------
> 
> (Updated Nov. 19, 2012, 10:28 p.m.)
> 
> 
> Review request for giraph.
> 
> 
> Description
> -------
> 
> Edge-based input from HCatalog
> 
> 
> This addresses bug GIRAPH-405.
>     https://issues.apache.org/jira/browse/GIRAPH-405
> 
> 
> Diffs
> -----
> 
>   /trunk/giraph-formats-contrib/pom.xml 1410684 
>   /trunk/giraph-formats-contrib/src/main/java/org/apache/giraph/io/hcatalog/GiraphHCatInputFormat.java
PRE-CREATION 
>   /trunk/giraph-formats-contrib/src/main/java/org/apache/giraph/io/hcatalog/HCatalogEdgeInputFormat.java
PRE-CREATION 
>   /trunk/giraph-formats-contrib/src/main/java/org/apache/giraph/io/hcatalog/HCatalogVertexInputFormat.java
1410684 
>   /trunk/giraph-formats-contrib/src/main/java/org/apache/giraph/io/hcatalog/HCatalogVertexOutputFormat.java
1410684 
>   /trunk/giraph-formats-contrib/src/main/java/org/apache/giraph/io/hcatalog/HCatalogVertexValueInputFormat.java
PRE-CREATION 
>   /trunk/giraph-formats-contrib/src/main/java/org/apache/giraph/io/hcatalog/HiveGiraphRunner.java
1410684 
>   /trunk/giraph-formats-contrib/src/main/java/org/apache/hcatalog/mapreduce/HCatUtils.java
PRE-CREATION 
>   /trunk/giraph-formats-contrib/src/main/java/org/apache/hcatalog/mapreduce/package-info.java
PRE-CREATION 
>   /trunk/pom.xml 1410684 
> 
> Diff: https://reviews.apache.org/r/8034/diff/
> 
> 
> Testing
> -------
> 
> - mvn verify
> - tested on a real application that runs on top of Hive
> 
> 
> Thanks,
> 
> Alessandro Presta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message