giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Avery Ching" <avery.ch...@gmail.com>
Subject Re: Review Request: GIRAPH-416: MasterObserver for user post-application customization
Date Fri, 16 Nov 2012 22:41:06 GMT


> On Nov. 9, 2012, 5:52 a.m., Avery Ching wrote:
> > giraph/src/main/java/org/apache/giraph/ImmutableClassesGiraphConfiguration.java,
lines 437-458
> > <https://reviews.apache.org/r/7981/diff/2/?file=187558#file187558line437>
> >
> >     These methods could be in GiraphConfiguration.  Methods in ImmmutableClassesGiraphConfiguration
should be for immutable variables (i.e. private final and assigned from the constructor) and
for fast acesss.
> 
> Nitay Joffe wrote:
>     I can move getMasterObserverClasses() but for createMasterObservers() I need to pass
in this so that it can get ImmmutableClassesGiraphConfigur-ed

Yeah, let's do that then.


- Avery


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7981/#review13284
-----------------------------------------------------------


On Nov. 9, 2012, 3:09 a.m., Nitay Joffe wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7981/
> -----------------------------------------------------------
> 
> (Updated Nov. 9, 2012, 3:09 a.m.)
> 
> 
> Review request for giraph.
> 
> 
> Description
> -------
> 
> GIRAPH-416: MasterObserver for user post-application customization
> 
> 
> Diffs
> -----
> 
>   giraph/src/main/java/org/apache/giraph/GiraphConfiguration.java 496bce7 
>   giraph/src/main/java/org/apache/giraph/ImmutableClassesGiraphConfiguration.java bb6a739

>   giraph/src/main/java/org/apache/giraph/bsp/CentralizedServiceMaster.java 688ce43 
>   giraph/src/main/java/org/apache/giraph/graph/BspServiceMaster.java 7d5dabb 
>   giraph/src/main/java/org/apache/giraph/graph/IntNullNullNullVertex.java PRE-CREATION

>   giraph/src/main/java/org/apache/giraph/graph/MasterThread.java 5c9a72d 
>   giraph/src/main/java/org/apache/giraph/io/IntNullNullNullTextInputFormat.java PRE-CREATION

>   giraph/src/main/java/org/apache/giraph/master/DefaultMasterObserver.java PRE-CREATION

>   giraph/src/main/java/org/apache/giraph/master/MasterObserver.java PRE-CREATION 
>   giraph/src/main/java/org/apache/giraph/master/package-info.java PRE-CREATION 
>   giraph/src/main/java/org/apache/giraph/utils/InternalVertexRunner.java b891690 
>   giraph/src/test/java/org/apache/giraph/TestGiraphConfiguration.java PRE-CREATION 
>   giraph/src/test/java/org/apache/giraph/TestMasterObserver.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/7981/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Nitay Joffe
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message