giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Avery Ching (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GIRAPH-412) Checkstyle error from Giraph-403
Date Tue, 06 Nov 2012 06:52:13 GMT

    [ https://issues.apache.org/jira/browse/GIRAPH-412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13491256#comment-13491256
] 

Avery Ching commented on GIRAPH-412:
------------------------------------

+1
                
> Checkstyle error from Giraph-403
> --------------------------------
>
>                 Key: GIRAPH-412
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-412
>             Project: Giraph
>          Issue Type: Bug
>            Reporter: Maja Kabiljo
>            Assignee: Maja Kabiljo
>         Attachments: GIRAPH-412.patch
>
>
> I didn't try to run mvn verify before committing GIRAPH-403. It complained about:
> "The double-checked locking idiom is broken and should be avoided."
> The reason why double-locking is bad doesn't apply here - it applies to cases where we
actually use the value of a variable which we are creating in this way.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message