Return-Path: X-Original-To: apmail-giraph-dev-archive@www.apache.org Delivered-To: apmail-giraph-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D7240D2B7 for ; Wed, 17 Oct 2012 19:46:59 +0000 (UTC) Received: (qmail 29521 invoked by uid 500); 17 Oct 2012 19:46:59 -0000 Delivered-To: apmail-giraph-dev-archive@giraph.apache.org Received: (qmail 29496 invoked by uid 500); 17 Oct 2012 19:46:59 -0000 Mailing-List: contact dev-help@giraph.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@giraph.apache.org Delivered-To: mailing list dev@giraph.apache.org Received: (qmail 29481 invoked by uid 99); 17 Oct 2012 19:46:59 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 17 Oct 2012 19:46:59 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 7083F1C45B9; Wed, 17 Oct 2012 19:46:57 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8831283715667785267==" MIME-Version: 1.0 Subject: Re: Review Request: GIRAPH-372: Write worker addresses to Zookeeper; move addresses and resolution to NettyClient From: "Maja Kabiljo" To: "Maja Kabiljo" , "Avery Ching" , "Eugene Koontz" , "giraph" , "Eli Reisman" Date: Wed, 17 Oct 2012 19:46:57 -0000 Message-ID: <20121017194657.16939.57635@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Maja Kabiljo" X-ReviewGroup: giraph X-ReviewRequest-URL: https://reviews.apache.org/r/7610/ X-Sender: "Maja Kabiljo" References: <20121016002429.16939.92405@reviews.apache.org> In-Reply-To: <20121016002429.16939.92405@reviews.apache.org> Reply-To: "Maja Kabiljo" --===============8831283715667785267== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7610/ ----------------------------------------------------------- (Updated Oct. 17, 2012, 7:46 p.m.) Review request for giraph. Changes ------- Rebased, addressed Avery's comments. Re-run tests (in both modes). Description ------- In preparation for GIRAPH-273, we need to have addresses of all workers ava= ilable, so I write them to Zookeeper along with the master address. Since address resoultion is needed in both NettyWorkerClient and NettyMaste= rClient, I moved that to NettyClient, and also added a map taskId->address = in there. Now NettyMasterClient and NettyWorkerClient don't need to take ca= re of InetSocketAddresses, just task ids which they want to send messages t= o. This addresses bug GIRAPH-372. https://issues.apache.org/jira/browse/GIRAPH-372 Diffs (updated) ----- http://svn.apache.org/repos/asf/giraph/trunk/giraph/src/main/java/org/apa= che/giraph/bsp/CentralizedServiceMaster.java 1399356 = http://svn.apache.org/repos/asf/giraph/trunk/giraph/src/main/java/org/apa= che/giraph/bsp/CentralizedServiceWorker.java 1399356 = http://svn.apache.org/repos/asf/giraph/trunk/giraph/src/main/java/org/apa= che/giraph/comm/MasterClient.java 1399356 = http://svn.apache.org/repos/asf/giraph/trunk/giraph/src/main/java/org/apa= che/giraph/comm/WorkerClient.java 1399356 = http://svn.apache.org/repos/asf/giraph/trunk/giraph/src/main/java/org/apa= che/giraph/comm/netty/NettyClient.java 1399356 = http://svn.apache.org/repos/asf/giraph/trunk/giraph/src/main/java/org/apa= che/giraph/comm/netty/NettyMasterClient.java 1399356 = http://svn.apache.org/repos/asf/giraph/trunk/giraph/src/main/java/org/apa= che/giraph/comm/netty/NettyMasterClientServer.java 1399356 = http://svn.apache.org/repos/asf/giraph/trunk/giraph/src/main/java/org/apa= che/giraph/comm/netty/NettyWorkerClient.java 1399356 = http://svn.apache.org/repos/asf/giraph/trunk/giraph/src/main/java/org/apa= che/giraph/comm/netty/NettyWorkerClientRequestProcessor.java 1399356 = http://svn.apache.org/repos/asf/giraph/trunk/giraph/src/main/java/org/apa= che/giraph/graph/AddressesAndPartitionsWritable.java PRE-CREATION = http://svn.apache.org/repos/asf/giraph/trunk/giraph/src/main/java/org/apa= che/giraph/graph/BspService.java 1399356 = http://svn.apache.org/repos/asf/giraph/trunk/giraph/src/main/java/org/apa= che/giraph/graph/BspServiceMaster.java 1399356 = http://svn.apache.org/repos/asf/giraph/trunk/giraph/src/main/java/org/apa= che/giraph/graph/BspServiceWorker.java 1399356 = http://svn.apache.org/repos/asf/giraph/trunk/giraph/src/main/java/org/apa= che/giraph/graph/InputSplitsCallable.java 1399356 = http://svn.apache.org/repos/asf/giraph/trunk/giraph/src/main/java/org/apa= che/giraph/graph/WorkerInfo.java 1399356 = http://svn.apache.org/repos/asf/giraph/trunk/giraph/src/main/java/org/apa= che/giraph/utils/WritableUtils.java 1399356 = http://svn.apache.org/repos/asf/giraph/trunk/giraph/src/test/java/org/apa= che/giraph/comm/ConnectionTest.java 1399356 = http://svn.apache.org/repos/asf/giraph/trunk/giraph/src/test/java/org/apa= che/giraph/comm/RequestFailureTest.java 1399356 = http://svn.apache.org/repos/asf/giraph/trunk/giraph/src/test/java/org/apa= che/giraph/comm/RequestTest.java 1399356 = http://svn.apache.org/repos/asf/giraph/trunk/giraph/src/test/java/org/apa= che/giraph/comm/SaslConnectionTest.java 1399356 = Diff: https://reviews.apache.org/r/7610/diff/ Testing ------- Passes mvn verify Thanks, Maja Kabiljo --===============8831283715667785267==--