giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Avery Ching (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GIRAPH-375) Cleaner MutableVertex API
Date Tue, 16 Oct 2012 22:59:04 GMT

    [ https://issues.apache.org/jira/browse/GIRAPH-375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13477439#comment-13477439
] 

Avery Ching commented on GIRAPH-375:
------------------------------------

How about 

Collections.emptyMap() instead of Maps.<I, E>newHashMapWithExpectedSize(0)?

                
> Cleaner MutableVertex API
> -------------------------
>
>                 Key: GIRAPH-375
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-375
>             Project: Giraph
>          Issue Type: Improvement
>            Reporter: Alessandro Presta
>            Assignee: Alessandro Presta
>         Attachments: GIRAPH-375.patch, GIRAPH-375.patch
>
>
> Currently, MutableVertex requires the user to instantiate a vertex before creating the
request.
> Using instantiateVertex() also requires a downcast to MutableVertex.
> What we can do instead is pass id and value (and optionally edges) to addVertexRequest(),
and the instantiation/initialization will happen internally and safely.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message