giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alessandro Presta (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GIRAPH-357) Don't try to combine if there is only one message
Date Fri, 05 Oct 2012 16:48:03 GMT

    [ https://issues.apache.org/jira/browse/GIRAPH-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13470447#comment-13470447
] 

Alessandro Presta commented on GIRAPH-357:
------------------------------------------

This change only helps when a lot of vertices have only one incoming message, right? Because
this event (originalMessageCount = 0) only happens when the first message is received.

I remember playing a bit with that number (combining only every X messages) and not seeing
any significant speedup, although intuition says we should.
If you have better evidence that it helps, we could even make the size configurable with a
default of 10 or something. You could try running some benchmarks with different values and
post the results.

                
> Don't try to combine if there is only one message
> -------------------------------------------------
>
>                 Key: GIRAPH-357
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-357
>             Project: Giraph
>          Issue Type: Improvement
>            Reporter: Maja Kabiljo
>            Assignee: Maja Kabiljo
>         Attachments: GIRAPH-357.patch
>
>
> In SendMessageCache, we call combiner even if we have just one message. Combining is
kind of expensive since we recreate the message object and the list. With default settings
and bigger graph, for PageRankBenchmark there is 10-15% superstep speedup if we don't call
it when we have a single message.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message