giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nitay Joffe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GIRAPH-376) Facebook Hadoop profile broken
Date Tue, 23 Oct 2012 09:07:12 GMT

    [ https://issues.apache.org/jira/browse/GIRAPH-376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13482214#comment-13482214
] 

Nitay Joffe commented on GIRAPH-376:
------------------------------------

Yep, here's what I did to test this patch:
1) Edit pom.xml replace ${hadoop.jar.path} with path to my Facebook Hadoop jar. Is there a
way to do this as some environment variable or something? I can also try updating the loop
script to pass this in as a command line option, but that seems kinda hacky - I like that
script as it is since it is completely generic (actually using it for other projects as well).
2) dev-support/for-each-profile.sh -DskipTests clean install

Ideally we can get rid of (1) by having FB hadoop jar published somewhere public.
We can also make (2) the recommended "really thorough" way to test patches or something? Obviously
other patches should remove -DskipTests, but right now I see some failures even in trunk and
this diff didn't touch any tests so I'm assuming they're not related.
                
> Facebook Hadoop profile broken
> ------------------------------
>
>                 Key: GIRAPH-376
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-376
>             Project: Giraph
>          Issue Type: Bug
>            Reporter: Nitay Joffe
>            Assignee: Nitay Joffe
>            Priority: Minor
>         Attachments: GIRAPH-376-2.patch, GIRAPH-376-3.patch, GIRAPH-376.patch
>
>
> Building against Facebook's Hadoop's jar is broken. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message