giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eugene Koontz (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GIRAPH-346) Top Level POM
Date Sat, 06 Oct 2012 03:34:03 GMT

    [ https://issues.apache.org/jira/browse/GIRAPH-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13470891#comment-13470891
] 

Eugene Koontz commented on GIRAPH-346:
--------------------------------------

I don't think this patch needs to be blocked by GIRAPH-211. As big as this restructuring is,
I can rewrite the GIRAPH-211 patch to match it. 

However, the current patch here fails when I try to apply it to trunk. One problem I noticed
is that the munge flag {{HADOOP_NON_SASL_RPC}} is used - it should no longer be used; it was
removed by GIRAPH-212 which is now committed to trunk.
                
> Top Level POM
> -------------
>
>                 Key: GIRAPH-346
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-346
>             Project: Giraph
>          Issue Type: Improvement
>            Reporter: Nitay Joffe
>            Assignee: Nitay Joffe
>            Priority: Minor
>         Attachments: GIRAPH-346.patch, readme.patch
>
>
> Most Maven projects that have multiple modules (as we do with main / formats) have a
top level pom.xml. This allows you avoid redundancy and also to build everything from top
level all at once. I'm using a lot of the formats stuff, especially playing with hive / hcatalog
and it's a pain having to constantly compile everything twice.
> So I propose we move all the main code under a subdir, say giraph/ or main/. Then add
a pom.xml that both the giraph/ and the formats/ subdirs can point to.
> Note we will still build completely separate jars. If people want to just build giraph-main
without formats they can do so directly from the subdirectory.
> Let me know if you guys +1 the idea and I'll whip it up.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message