giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Avery Ching (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GIRAPH-357) Don't try to combine if there is only one message
Date Fri, 05 Oct 2012 17:38:04 GMT

    [ https://issues.apache.org/jira/browse/GIRAPH-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13470493#comment-13470493
] 

Avery Ching commented on GIRAPH-357:
------------------------------------

This is a great find.  I would suggest adding something to the below code to an option to
use / not use a client side combiner.

{code}
  public SendMessageCache(ImmutableClassesGiraphConfiguration conf) {
    if (conf.getVertexCombinerClass() == null) {
      this.combiner = null;
    } else {
      this.combiner = conf.createVertexCombiner();
    }
  }
{code}
                
> Don't try to combine if there is only one message
> -------------------------------------------------
>
>                 Key: GIRAPH-357
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-357
>             Project: Giraph
>          Issue Type: Improvement
>            Reporter: Maja Kabiljo
>            Assignee: Maja Kabiljo
>         Attachments: GIRAPH-357.patch
>
>
> In SendMessageCache, we call combiner even if we have just one message. Combining is
kind of expensive since we recreate the message object and the list. With default settings
and bigger graph, for PageRankBenchmark there is 10-15% superstep speedup if we don't call
it when we have a single message.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message