giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Avery Ching" <avery.ch...@gmail.com>
Subject Re: Review Request: GIRAPH-232: Add metrics system into Giraph
Date Wed, 31 Oct 2012 17:10:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7595/#review12936
-----------------------------------------------------------


A suggestion on the naming, perhaps rather than EmptyCounter, EmptyExecutorService, they could
be called NoOpCounter and NoOpExecutorService?  Not sure if that's clearer or not, but empty
had me confused for a bit.

I assume this passed mvn clean install?


giraph/src/main/java/org/apache/giraph/graph/BspServiceWorker.java
<https://reviews.apache.org/r/7595/#comment27867>

    initGauges



giraph/src/main/java/org/apache/giraph/graph/BspServiceWorker.java
<https://reviews.apache.org/r/7595/#comment27842>

    gauges



giraph/src/main/java/org/apache/giraph/graph/BspServiceWorker.java
<https://reviews.apache.org/r/7595/#comment27844>

    You might want to add these methods to GiraphConfiguration



giraph/src/main/java/org/apache/giraph/graph/BspServiceWorker.java
<https://reviews.apache.org/r/7595/#comment27843>

    worker



giraph/src/main/java/org/apache/giraph/graph/partition/HashWorkerPartitioner.java
<https://reviews.apache.org/r/7595/#comment27846>

    What's wrong with the Guava one here?


- Avery Ching


On Oct. 31, 2012, 3:04 a.m., Nitay Joffe wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7595/
> -----------------------------------------------------------
> 
> (Updated Oct. 31, 2012, 3:04 a.m.)
> 
> 
> Review request for giraph.
> 
> 
> Description
> -------
> 
> GIRAPH-232: Add metrics system into Giraph
> 
> 
> Diffs
> -----
> 
>   giraph/pom.xml 655b0f0fc25910be80dda908dcc789a166ad23f1 
>   giraph/src/main/java/com/yammer/metrics/core/EmptyCounter.java PRE-CREATION 
>   giraph/src/main/java/com/yammer/metrics/core/EmptyExecutorService.java PRE-CREATION

>   giraph/src/main/java/com/yammer/metrics/core/EmptyHistogram.java PRE-CREATION 
>   giraph/src/main/java/com/yammer/metrics/core/EmptyMeter.java PRE-CREATION 
>   giraph/src/main/java/com/yammer/metrics/core/EmptyTimer.java PRE-CREATION 
>   giraph/src/main/java/com/yammer/metrics/core/NullGuage.java PRE-CREATION 
>   giraph/src/main/java/com/yammer/metrics/core/package-info.java PRE-CREATION 
>   giraph/src/main/java/org/apache/giraph/comm/WorkerClientRequestProcessor.java 210fbd56dbdc01e67e0ba09c64c266ac97c2eae9

>   giraph/src/main/java/org/apache/giraph/comm/netty/ByteCounter.java f228375a7398a6c38134a38bf2055a17a998a204

>   giraph/src/main/java/org/apache/giraph/comm/netty/NettyWorkerClientRequestProcessor.java
45dabe1b1fa58035804cce0fee02e882329d1dc6 
>   giraph/src/main/java/org/apache/giraph/graph/BspServiceMaster.java d68debc41b44e20c0dcb5907d1a1b398b759b149

>   giraph/src/main/java/org/apache/giraph/graph/BspServiceWorker.java 194833c2c0af421de601e2d264e967c026d33d3e

>   giraph/src/main/java/org/apache/giraph/graph/ComputeCallable.java 8602c92ca59c1babfae6bc11059c7dc4f96d4993

>   giraph/src/main/java/org/apache/giraph/graph/GraphMapper.java f80c54c953ff7ae21e0e2b3cf8610815356d3166

>   giraph/src/main/java/org/apache/giraph/graph/InputSplitsCallable.java cf6b1821cad98b8d4bda8b9502df0aad3ad461dd

>   giraph/src/main/java/org/apache/giraph/graph/Vertex.java 4118c3176bd4a9c7d00dc0bd717e591d74886e9c

>   giraph/src/main/java/org/apache/giraph/graph/partition/HashWorkerPartitioner.java 9f5bf97fd083190cab7b1a044d7f375ed5feaaad

>   giraph/src/main/java/org/apache/giraph/metrics/EmptyMetricsRegistry.java PRE-CREATION

>   giraph/src/main/java/org/apache/giraph/metrics/GiraphMetrics.java PRE-CREATION 
>   giraph/src/main/java/org/apache/giraph/metrics/MetricGroup.java PRE-CREATION 
>   giraph/src/main/java/org/apache/giraph/metrics/package-info.java PRE-CREATION 
>   giraph/src/main/java/org/apache/giraph/utils/MemoryUtils.java 8fc403201b784bd4dab733d6764d1cf7ed0295a6

>   pom.xml c0842192a1629ecf98273c51d7185295da52f9cd 
> 
> Diff: https://reviews.apache.org/r/7595/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Nitay Joffe
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message