giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nitay Joffe" <ni...@apache.org>
Subject Re: Review Request: GIRAPH-232: Add metrics system into Giraph
Date Thu, 25 Oct 2012 07:51:42 GMT


> On Oct. 16, 2012, 4:45 a.m., Avery Ching wrote:
> > giraph/src/main/java/org/apache/giraph/graph/GraphMapper.java, lines 401-403
> > <https://reviews.apache.org/r/7595/diff/1/?file=176669#file176669line401>
> >
> >     This looks unnecessary?

whoops :)


> On Oct. 16, 2012, 4:45 a.m., Avery Ching wrote:
> > giraph/src/main/java/org/apache/giraph/metrics/GiraphMetrics.java, lines 42-55
> > <https://reviews.apache.org/r/7595/diff/1/?file=176672#file176672line42>
> >
> >     Minor style thing: Most of the code follows = on the previous line.

sg, we should add checkstyle rules for this so it warns me / others next time?


> On Oct. 16, 2012, 4:45 a.m., Avery Ching wrote:
> > giraph/src/main/java/org/apache/giraph/metrics/GiraphMetrics.java, lines 69-72
> > <https://reviews.apache.org/r/7595/diff/1/?file=176672#file176672line69>
> >
> >     Most of the other javadoc comments have a line in between (i.e. 
> >     
> >     /**
> >      * Initialize the GiraphMetrics
> >      *
> >      * @param context Mapper context
> >      */
> >     
> >     Would be great to make this a bit more uniform.

sg, another checkstyle change?


- Nitay


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7595/#review12468
-----------------------------------------------------------


On Oct. 25, 2012, 7:51 a.m., Nitay Joffe wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7595/
> -----------------------------------------------------------
> 
> (Updated Oct. 25, 2012, 7:51 a.m.)
> 
> 
> Review request for giraph.
> 
> 
> Description
> -------
> 
> GIRAPH-232: Add metrics system into Giraph
> 
> 
> Diffs
> -----
> 
>   giraph/pom.xml 31da7b45d90104459be07eefe28d59f71fd42c3b 
>   giraph/src/main/java/com/yammer/metrics/core/EmptyCounter.java PRE-CREATION 
>   giraph/src/main/java/com/yammer/metrics/core/EmptyExecutorService.java PRE-CREATION

>   giraph/src/main/java/com/yammer/metrics/core/EmptyHistogram.java PRE-CREATION 
>   giraph/src/main/java/com/yammer/metrics/core/EmptyMeter.java PRE-CREATION 
>   giraph/src/main/java/com/yammer/metrics/core/EmptyTimer.java PRE-CREATION 
>   giraph/src/main/java/com/yammer/metrics/core/NullGuage.java PRE-CREATION 
>   giraph/src/main/java/com/yammer/metrics/core/package-info.java PRE-CREATION 
>   giraph/src/main/java/org/apache/giraph/comm/WorkerClientRequestProcessor.java 210fbd56dbdc01e67e0ba09c64c266ac97c2eae9

>   giraph/src/main/java/org/apache/giraph/comm/netty/ByteCounter.java f228375a7398a6c38134a38bf2055a17a998a204

>   giraph/src/main/java/org/apache/giraph/comm/netty/NettyClient.java 3814d12ae42be89a3cf24579a03ba776c03ef06f

>   giraph/src/main/java/org/apache/giraph/comm/netty/NettyWorkerClientRequestProcessor.java
45dabe1b1fa58035804cce0fee02e882329d1dc6 
>   giraph/src/main/java/org/apache/giraph/graph/BspServiceMaster.java 3e659a672baabffd4a5a0824d46f1e705e7354cc

>   giraph/src/main/java/org/apache/giraph/graph/BspServiceWorker.java cb3cb9c8a725830efb2e58abcd995ef27ef2fc80

>   giraph/src/main/java/org/apache/giraph/graph/ComputeCallable.java 8602c92ca59c1babfae6bc11059c7dc4f96d4993

>   giraph/src/main/java/org/apache/giraph/graph/GraphMapper.java 5092f29d48a03794b2f5d45d7996fad330ae0e40

>   giraph/src/main/java/org/apache/giraph/graph/InputSplitsCallable.java e953b11d5e4d07fd0cd82281a89b950af62839ff

>   giraph/src/main/java/org/apache/giraph/graph/Vertex.java 4118c3176bd4a9c7d00dc0bd717e591d74886e9c

>   giraph/src/main/java/org/apache/giraph/graph/partition/HashWorkerPartitioner.java 9f5bf97fd083190cab7b1a044d7f375ed5feaaad

>   giraph/src/main/java/org/apache/giraph/metrics/EmptyMetricsRegistry.java PRE-CREATION

>   giraph/src/main/java/org/apache/giraph/metrics/GiraphMetrics.java PRE-CREATION 
>   giraph/src/main/java/org/apache/giraph/metrics/MetricGroup.java PRE-CREATION 
>   giraph/src/main/java/org/apache/giraph/metrics/package-info.java PRE-CREATION 
>   giraph/src/main/java/org/apache/giraph/utils/GiraphTimer.java PRE-CREATION 
>   giraph/src/main/java/org/apache/giraph/utils/MemoryUtils.java 8fc403201b784bd4dab733d6764d1cf7ed0295a6

>   giraph/src/main/java/org/apache/giraph/utils/MilliSecTimer.java PRE-CREATION 
>   pom.xml 1fd2791bf42df465f532fbdacfd1979e6b4b3857 
> 
> Diff: https://reviews.apache.org/r/7595/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Nitay Joffe
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message