giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Avery Ching" <avery.ch...@gmail.com>
Subject Re: Review Request: GIRAPH-385: script for running on all profiles
Date Tue, 23 Oct 2012 04:12:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7703/#review12675
-----------------------------------------------------------

Ship it!


+1, lgtm.

- Avery Ching


On Oct. 23, 2012, 2:27 a.m., Nitay Joffe wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7703/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2012, 2:27 a.m.)
> 
> 
> Review request for giraph.
> 
> 
> Description
> -------
> 
> GIRAPH-385: script for running on all profiles
> 
> Uses xpath so that there is no hardcoding, that is all profiles are parsed from pom.xmls
themselves.
> Breaks on first profile that fails.
> 
> Sample output: https://gist.github.com/ff453de2177b57c7a1b0
> 
> 
> Diffs
> -----
> 
>   dev-support/for-each-profile.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/7703/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Nitay Joffe
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message