giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nitay Joffe" <ni...@apache.org>
Subject Re: Review Request: GIRAPH-384: Remove duplicate BspCase in giraph-formats-contrib (and fix GIRAPH-382 breaking the build)
Date Tue, 23 Oct 2012 02:03:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7702/#review12674
-----------------------------------------------------------



http://svn.apache.org/repos/asf/giraph/trunk/giraph-formats-contrib/pom.xml
<https://reviews.apache.org/r/7702/#comment27028>

    move this to top level pom, use ${project.version}



http://svn.apache.org/repos/asf/giraph/trunk/giraph-formats-contrib/src/test/java/org/apache/giraph/io/accumulo/TestAccumuloVertexFormat.java
<https://reviews.apache.org/r/7702/#comment27029>

    Why not getClass()?


- Nitay Joffe


On Oct. 23, 2012, 1:03 a.m., Avery Ching wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7702/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2012, 1:03 a.m.)
> 
> 
> Review request for giraph.
> 
> 
> Description
> -------
> 
> giraph-formats-contrib can now use the giraph test jar instead of duplicating code.
> 
> 
> This addresses bug GIRAPH-384.
>     https://issues.apache.org/jira/browse/GIRAPH-384
> 
> 
> Diffs
> -----
> 
>   http://svn.apache.org/repos/asf/giraph/trunk/giraph-formats-contrib/pom.xml 1401120

>   http://svn.apache.org/repos/asf/giraph/trunk/giraph-formats-contrib/src/test/java/org/apache/giraph/BspCase.java
1401120 
>   http://svn.apache.org/repos/asf/giraph/trunk/giraph-formats-contrib/src/test/java/org/apache/giraph/io/accumulo/TestAccumuloVertexFormat.java
1401120 
>   http://svn.apache.org/repos/asf/giraph/trunk/giraph-formats-contrib/src/test/java/org/apache/giraph/io/hbase/TestHBaseRootMarkerVertextFormat.java
1401120 
>   http://svn.apache.org/repos/asf/giraph/trunk/giraph-formats-contrib/src/test/java/org/apache/giraph/io/hcatalog/TestHiveUtils.java
1401120 
> 
> Diff: https://reviews.apache.org/r/7702/diff/
> 
> 
> Testing
> -------
> 
> mvn clean install
> 
> 
> Thanks,
> 
> Avery Ching
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message