giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nitay Joffe (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (GIRAPH-376) Facebook Hadoop profile broken
Date Sat, 20 Oct 2012 07:34:12 GMT

     [ https://issues.apache.org/jira/browse/GIRAPH-376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Nitay Joffe updated GIRAPH-376:
-------------------------------

    Attachment: GIRAPH-376-2.patch

Okay yeah I see the issue now. The profiles weren't getting inherited correctly from the top
level. Here's the fix. Looks like a lot but basically is just moving profile metadata up to
top level so it's inherited by everyone. Couple of changes I did actually make:

1) Sorted dependencies in pom.xmls lexicographically. No logic change.
2) Minor hack in LoggerUtils.java because hadoop_0.23 TaskAttemptContext#setStatus() doesn't
throw IOException and was causing compile error.
3) Change group of commons-io from org.apache.commons to commons-io (was throwing a warning).
4) Add that commons-collections dependency that was missing.

Other than that there is no logic change. I tested on all profiles.
                
> Facebook Hadoop profile broken
> ------------------------------
>
>                 Key: GIRAPH-376
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-376
>             Project: Giraph
>          Issue Type: Bug
>            Reporter: Nitay Joffe
>            Assignee: Nitay Joffe
>            Priority: Trivial
>         Attachments: GIRAPH-376-2.patch, GIRAPH-376.patch
>
>
> Building against Facebook's Hadoop's jar is broken. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message