giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Doron Cohen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GIRAPH-42) The MapReduce counter 'Sent Messages' doesn't work.
Date Thu, 18 Oct 2012 18:16:04 GMT

    [ https://issues.apache.org/jira/browse/GIRAPH-42?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13479206#comment-13479206
] 

Doron Cohen commented on GIRAPH-42:
-----------------------------------

Hi, now I am not sure that my first patch here addresses the problem discussed in this issue.


The problem I saw is that the sent messages counter is always 0, and 
I think the cause for always-zero-count are these lines in BspServiceMaster:

{code}
  updateCounters(GlobalStats globalStats) {
    ...
    sentMessagesCounter.increment(
        globalStats.getMessageCount() -
            sentMessagesCounter.getValue());
  }
{code}

The thing is that globalStats messages-count is updated via calls to WorkerClientRequestProcessor.resetMessageCount().
Since resetMessageCount() sets the local counter to 0, it seems the current code simply shows
the number of  messages 
sent in the last superstep, Which is always 0, I think.
So, it is wrong to subtract sentMessagesCounter.getValue(), instead, just need to add globalStats.getMessageCount().

I think this issue is originally about something else - how to consider combined messages
in the messages counts.
>From what I could understand in the code the current approach is (1): 

bq. 1. Increment the Counter in the sentMsg Method in Vertex -> If messages are combined
it does not show up in the Counter.

(anyhow I could not find where the code attempts to do (3).)

Updated patch to follow, assuming this problem should be fixed i this issue, or is a new issue
required?
                
> The MapReduce counter 'Sent Messages' doesn't work.
> ---------------------------------------------------
>
>                 Key: GIRAPH-42
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-42
>             Project: Giraph
>          Issue Type: Bug
>          Components: bsp
>            Reporter: Hyunsik Choi
>            Priority: Minor
>         Attachments: GIRAPH-42.patch
>
>
> The MapReduce counter 'Sent Messages' doesn't work. It always shows 0.
> {noformat}
> .
> .
> 11/09/28 10:51:22 INFO mapred.JobClient:     Current workers=20
> 11/09/28 10:51:22 INFO mapred.JobClient:     Current master task partition=0
> 11/09/28 10:51:22 INFO mapred.JobClient:     Sent messages=0
> 11/09/28 10:51:22 INFO mapred.JobClient:     Aggregate finished vertices=600000
> 11/09/28 10:51:22 INFO mapred.JobClient:     Aggregate vertices=600000
> .
> .
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message