giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maja Kabiljo (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GIRAPH-372) Write worker addresses to Zookeeper; move addresses and resolution to NettyClient
Date Wed, 17 Oct 2012 06:46:03 GMT

    [ https://issues.apache.org/jira/browse/GIRAPH-372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13477668#comment-13477668
] 

Maja Kabiljo commented on GIRAPH-372:
-------------------------------------

Eugene, I saw GIRAPH-362 but I don't really understand where the issue comes from. Doesn't
master also have task id? I see:
{code:title=NettyWorkerClient.java}
addressTaskIdMap.put(service.getMasterInfo().getInetSocketAddress(), null);
{code}
Would the problem be solved if we just put service.getMasterInfo().getTaskId() instead of
null? Or am I missing something obvious?
                
> Write worker addresses to Zookeeper; move addresses and resolution to NettyClient
> ---------------------------------------------------------------------------------
>
>                 Key: GIRAPH-372
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-372
>             Project: Giraph
>          Issue Type: Improvement
>            Reporter: Maja Kabiljo
>            Assignee: Maja Kabiljo
>         Attachments: GIRAPH-372.patch
>
>
> In preparation for GIRAPH-273, we need to have addresses of all workers available, so
I write them to Zookeeper along with the master address.
> Since address resoultion is needed in both NettyWorkerClient and NettyMasterClient, I
moved that to NettyClient, and also added a map taskId->address in there. Now NettyMasterClient
and NettyWorkerClient don't need to take care of InetSocketAddresses, just task ids which
they want to send messages to.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message