Return-Path: X-Original-To: apmail-giraph-dev-archive@www.apache.org Delivered-To: apmail-giraph-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id CFD22DEBE for ; Thu, 27 Sep 2012 05:52:44 +0000 (UTC) Received: (qmail 94512 invoked by uid 500); 27 Sep 2012 05:52:44 -0000 Delivered-To: apmail-giraph-dev-archive@giraph.apache.org Received: (qmail 94471 invoked by uid 500); 27 Sep 2012 05:52:44 -0000 Mailing-List: contact dev-help@giraph.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@giraph.apache.org Delivered-To: mailing list dev@giraph.apache.org Received: (qmail 94462 invoked by uid 99); 27 Sep 2012 05:52:44 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 27 Sep 2012 05:52:44 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id EBF281C439E; Thu, 27 Sep 2012 05:52:42 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5130777861118643872==" MIME-Version: 1.0 Subject: Re: Review Request: GIRAPH-336 From: "Avery Ching" To: "Avery Ching" , "giraph" Date: Thu, 27 Sep 2012 05:52:42 -0000 Message-ID: <20120927055242.18992.86271@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Avery Ching" X-ReviewGroup: giraph X-ReviewRequest-URL: https://reviews.apache.org/r/7310/ X-Sender: "Avery Ching" References: <20120927055240.18991.32268@reviews.apache.org> In-Reply-To: <20120927055240.18991.32268@reviews.apache.org> Reply-To: "Avery Ching" --===============5130777861118643872== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7310/#review11965 ----------------------------------------------------------- http://svn.apache.org/repos/asf/giraph/trunk/giraph-formats-contrib/pom.xml Do we need this? How did it build before? http://svn.apache.org/repos/asf/giraph/trunk/giraph-formats-contrib/src/hca= talog/java/org/apache/giraph/format/hcatalog/HCatalogVertexInputFormat.java Would be nice to align these comments with the variable indent. This h= appens a lot in this code. http://svn.apache.org/repos/asf/giraph/trunk/giraph-formats-contrib/src/hca= talog/java/org/apache/giraph/format/hcatalog/HCatalogVertexInputFormat.java shouldn't this be static (and capitalized)? http://svn.apache.org/repos/asf/giraph/trunk/giraph-formats-contrib/src/hca= talog/java/org/apache/giraph/format/hcatalog/HCatalogVertexInputFormat.java These should be converted to using log4j, not just removed. http://svn.apache.org/repos/asf/giraph/trunk/giraph-formats-contrib/src/hca= talog/java/org/apache/giraph/format/hcatalog/HCatalogVertexInputFormat.java Please keep with log4j http://svn.apache.org/repos/asf/giraph/trunk/giraph-formats-contrib/src/hca= talog/java/org/apache/giraph/format/hcatalog/HiveGiraphRunner.java Convert to using logj4? http://svn.apache.org/repos/asf/giraph/trunk/giraph-formats-contrib/src/mai= n/java/org/apache/giraph/format/accumulo/AccumuloVertexInputFormat.java Why remove? http://svn.apache.org/repos/asf/giraph/trunk/giraph-formats-contrib/src/mai= n/java/org/apache/giraph/format/accumulo/AccumuloVertexInputFormat.java Why remove? http://svn.apache.org/repos/asf/giraph/trunk/giraph-formats-contrib/src/mai= n/java/org/apache/giraph/format/accumulo/AccumuloVertexOutputFormat.java Why remove? http://svn.apache.org/repos/asf/giraph/trunk/giraph-formats-contrib/src/mai= n/java/org/apache/giraph/format/accumulo/AccumuloVertexOutputFormat.java Why remove? - Avery Ching On Sept. 27, 2012, 5:52 a.m., Avery Ching wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7310/ > ----------------------------------------------------------- > = > (Updated Sept. 27, 2012, 5:52 a.m.) > = > = > Review request for giraph. > = > = > Description > ------- > = > Review of GIRAPH-336.patch for Brian. > = > FYI, this fails to patch cleanly for me. > = > aching@achingmbp15:~/git/git_svn_giraph_trunk$ git status > # On branch GIRAPH-328 > nothing to commit (working directory clean) > aching@achingmbp15:~/git/git_svn_giraph_trunk$ patch -p0 < ~/Desktop/GIRA= PH-336.patch = > patching file giraph-formats-contrib/src/hcatalog/java/org/apache/giraph/= format/hcatalog/HiveGiraphRunner.java > Hunk #1 FAILED at 45. > 1 out of 1 hunk FAILED -- saving rejects to file giraph-formats-contrib/s= rc/hcatalog/java/org/apache/giraph/format/hcatalog/HiveGiraphRunner.java.rej > patching file giraph-formats-contrib/src/hcatalog/java/org/apache/giraph/= format/hcatalog/HCatalogVertexInputFormat.java > patching file giraph-formats-contrib/src/hcatalog/java/org/apache/giraph/= format/hcatalog/HCatalogVertexOutputFormat.java > patching file giraph-formats-contrib/src/main/java/org/apache/giraph/form= at/accumulo/AccumuloVertexInputFormat.java > patching file giraph-formats-contrib/src/main/java/org/apache/giraph/form= at/accumulo/AccumuloVertexOutputFormat.java > patching file giraph-formats-contrib/pom.xml > = > = > Diffs > ----- > = > http://svn.apache.org/repos/asf/giraph/trunk/giraph-formats-contrib/pom= .xml 1389474 = > http://svn.apache.org/repos/asf/giraph/trunk/giraph-formats-contrib/src= /hcatalog/java/org/apache/giraph/format/hcatalog/HCatalogVertexInputFormat.= java 1389474 = > http://svn.apache.org/repos/asf/giraph/trunk/giraph-formats-contrib/src= /hcatalog/java/org/apache/giraph/format/hcatalog/HCatalogVertexOutputFormat= .java 1389474 = > http://svn.apache.org/repos/asf/giraph/trunk/giraph-formats-contrib/src= /hcatalog/java/org/apache/giraph/format/hcatalog/HiveGiraphRunner.java 1389= 474 = > http://svn.apache.org/repos/asf/giraph/trunk/giraph-formats-contrib/src= /main/java/org/apache/giraph/format/accumulo/AccumuloVertexInputFormat.java= 1389474 = > http://svn.apache.org/repos/asf/giraph/trunk/giraph-formats-contrib/src= /main/java/org/apache/giraph/format/accumulo/AccumuloVertexOutputFormat.jav= a 1389474 = > = > Diff: https://reviews.apache.org/r/7310/diff/ > = > = > Testing > ------- > = > = > Thanks, > = > Avery Ching > = > --===============5130777861118643872==--