Return-Path: X-Original-To: apmail-giraph-dev-archive@www.apache.org Delivered-To: apmail-giraph-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 89055DE5F for ; Thu, 27 Sep 2012 05:33:02 +0000 (UTC) Received: (qmail 43340 invoked by uid 500); 27 Sep 2012 05:33:02 -0000 Delivered-To: apmail-giraph-dev-archive@giraph.apache.org Received: (qmail 43302 invoked by uid 500); 27 Sep 2012 05:33:02 -0000 Mailing-List: contact dev-help@giraph.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@giraph.apache.org Delivered-To: mailing list dev@giraph.apache.org Received: (qmail 43288 invoked by uid 99); 27 Sep 2012 05:33:02 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 27 Sep 2012 05:33:02 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 868B81C439E; Thu, 27 Sep 2012 05:33:00 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2835089772346391489==" MIME-Version: 1.0 Subject: Re: Review Request: GIRAPH-328.5 From: "Avery Ching" To: "Avery Ching" , "giraph" Date: Thu, 27 Sep 2012 05:33:00 -0000 Message-ID: <20120927053300.18994.46218@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Avery Ching" X-ReviewGroup: giraph X-ReviewRequest-URL: https://reviews.apache.org/r/7308/ X-Sender: "Avery Ching" References: <20120927053254.18994.55175@reviews.apache.org> In-Reply-To: <20120927053254.18994.55175@reviews.apache.org> Reply-To: "Avery Ching" --===============2835089772346391489== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7308/#review11964 ----------------------------------------------------------- src/main/java/org/apache/giraph/comm/SendMessageCache.java Would be nice to change this to = "for all workers" src/main/java/org/apache/giraph/comm/messages/SimpleMessageStore.java Thank you for fixing this! src/main/java/org/apache/giraph/comm/messages/SimpleMessageStore.java Good catch! src/main/java/org/apache/giraph/comm/netty/NettyWorkerClient.java I see what you are doing, but couldn't we instead have another method = = getInetSocketAddress(WorkerInfo workerInfo) = = that does this instead of sending in an unexpected partition id? This = seems a little hacky. = At the very least, we should modify the javadoc for @param partitionId = to reflect that we do expect USE_WORKERINFO_ADDRESS in some cases. src/main/java/org/apache/giraph/comm/netty/NettyWorkerClient.java This could just use the new method getInetSocketAddress(entry.getKey) I= suggested earlier. src/main/java/org/apache/giraph/comm/requests/SendPartitionCurrentMessagesR= equest.java Please remove. src/main/java/org/apache/giraph/comm/requests/SendPartitionCurrentMessagesR= equest.java getConf().createVertexId() instead please, shouldn't use BspUtils anymo= re. src/main/java/org/apache/giraph/comm/requests/SendPartitionCurrentMessagesR= equest.java Please no BspUtils. src/main/java/org/apache/giraph/comm/requests/SendWorkerMessagesRequest.java Messages sent for one or more partitions? - Avery Ching On Sept. 27, 2012, 5:32 a.m., Avery Ching wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7308/ > ----------------------------------------------------------- > = > (Updated Sept. 27, 2012, 5:32 a.m.) > = > = > Review request for giraph. > = > = > Description > ------- > = > Review of Eli's GIRAPH-328.5.patch. Reviewboard helps me to be more prec= ise about my comments. > = > = > Diffs > ----- > = > src/main/java/org/apache/giraph/comm/SendMessageCache.java 3d38712 = > src/main/java/org/apache/giraph/comm/messages/SimpleMessageStore.java c= e0e64c = > src/main/java/org/apache/giraph/comm/netty/NettyWorkerClient.java f3a8d= 4f = > src/main/java/org/apache/giraph/comm/requests/RequestType.java 4fbf692 = > src/main/java/org/apache/giraph/comm/requests/SendPartitionCurrentMessa= gesRequest.java 7cae1e2 = > src/main/java/org/apache/giraph/comm/requests/SendPartitionMessagesRequ= est.java 1b3a435 = > src/main/java/org/apache/giraph/comm/requests/SendWorkerMessagesRequest= .java PRE-CREATION = > src/main/java/org/apache/giraph/graph/BspServiceMaster.java 18b5387 = > src/main/java/org/apache/giraph/graph/WorkerInfo.java 0224d87 = > src/test/java/org/apache/giraph/comm/RequestFailureTest.java 02f699f = > src/test/java/org/apache/giraph/comm/RequestTest.java aa0ddd2 = > = > Diff: https://reviews.apache.org/r/7308/diff/ > = > = > Testing > ------- > = > mvn clean verify > = > = > Thanks, > = > Avery Ching > = > --===============2835089772346391489==--