giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Avery Ching (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GIRAPH-332) Duplicate unnecessary info in giraph-formats-contrib compile.xml
Date Thu, 20 Sep 2012 06:11:07 GMT

    [ https://issues.apache.org/jira/browse/GIRAPH-332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13459374#comment-13459374
] 

Avery Ching commented on GIRAPH-332:
------------------------------------

Nitay, my compile.xml looks like it only has one copy.

{code}
 cat src/main/assembly/compile.xml 
<!--
   Licensed to the Apache Software Foundation (ASF) under one or more
   contributor license agreements.  See the NOTICE file distributed with
   this work for additional information regarding copyright ownership.
   The ASF licenses this file to You under the Apache License, Version 2.0
   (the "License"); you may not use this file except in compliance with
   the License.  You may obtain a copy of the License at

       http://www.apache.org/licenses/LICENSE-2.0

   Unless required by applicable law or agreed to in writing, software
   distributed under the License is distributed on an "AS IS" BASIS,
   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
   See the License for the specific language governing permissions and
   limitations under the License.
-->
<assembly xmlns="http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.0"
  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
  xsi:schemaLocation="http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.0
http://maven.apache.org/xsd/assembly-1.1.0.xsd">
  <id>jar-with-dependencies</id>
   <formats>
    <format>jar</format>
  </formats>
  <includeBaseDirectory>false</includeBaseDirectory>

  <dependencySets>
    <dependencySet>
      <useProjectArtifact>true</useProjectArtifact>
      <outputDirectory>/</outputDirectory>
      <unpackOptions>
        <excludes>
          <exclude>
	    META-INF/LICENSE
          </exclude>
        </excludes>
      </unpackOptions>
      <unpack>true</unpack>
      <scope>runtime</scope>
    </dependencySet>
  </dependencySets>
</assembly>
{code}
                
> Duplicate unnecessary info in giraph-formats-contrib compile.xml
> ----------------------------------------------------------------
>
>                 Key: GIRAPH-332
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-332
>             Project: Giraph
>          Issue Type: Improvement
>            Reporter: Nitay Joffe
>            Assignee: Nitay Joffe
>            Priority: Trivial
>         Attachments: GIRAPH-332.txt
>
>
> Pretty straightforward. While working on GIRAPH-93 I found that we have three copies
of the XML in compile.xml for giraph-formats-contrib. Seems bit unnecessary?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message