giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Avery Ching" <avery.ch...@gmail.com>
Subject Re: Review Request: GIRAPH-328.5
Date Sun, 30 Sep 2012 04:43:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7308/
-----------------------------------------------------------

(Updated Sept. 30, 2012, 4:42 a.m.)


Review request for giraph.


Description
-------

Review of Eli's GIRAPH-328.5.patch.  Reviewboard helps me to be more precise about my comments.


This addresses bug GIRAPH-328.
    https://issues.apache.org/jira/browse/GIRAPH-328


Diffs
-----

  src/main/java/org/apache/giraph/comm/SendMessageCache.java 3d38712 
  src/main/java/org/apache/giraph/comm/messages/SimpleMessageStore.java ce0e64c 
  src/main/java/org/apache/giraph/comm/netty/NettyWorkerClient.java 126b18e 
  src/main/java/org/apache/giraph/comm/requests/RequestType.java 4fbf692 
  src/main/java/org/apache/giraph/comm/requests/SendPartitionCurrentMessagesRequest.java 7cae1e2

  src/main/java/org/apache/giraph/comm/requests/SendPartitionMessagesRequest.java 1b3a435

  src/main/java/org/apache/giraph/comm/requests/SendWorkerMessagesRequest.java PRE-CREATION

  src/main/java/org/apache/giraph/graph/BspServiceMaster.java 6edd31e 
  src/main/java/org/apache/giraph/graph/WorkerInfo.java 0224d87 
  src/test/java/org/apache/giraph/comm/RequestFailureTest.java 02f699f 
  src/test/java/org/apache/giraph/comm/RequestTest.java aa0ddd2 

Diff: https://reviews.apache.org/r/7308/diff/


Testing
-------

mvn clean verify


Thanks,

Avery Ching


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message