giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Avery Ching" <avery.ch...@gmail.com>
Subject Re: Review Request: GIRAPH-328.5
Date Sun, 30 Sep 2012 04:42:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7308/#review12044
-----------------------------------------------------------


This is close Eli, I'm noted a few things.  I'll be submitting a fixed diff for you.  Let
me know what you think and we can commit your good work!


src/main/java/org/apache/giraph/comm/netty/NettyWorkerClient.java
<https://reviews.apache.org/r/7308/#comment25669>

    This comment is a bit strangely worded.  Perhaps something like
    
    // Only cache the valid partition ids



src/main/java/org/apache/giraph/comm/netty/NettyWorkerClient.java
<https://reviews.apache.org/r/7308/#comment25670>

    getInetSocketAddress -> resolveAddress



src/main/java/org/apache/giraph/comm/netty/NettyWorkerClient.java
<https://reviews.apache.org/r/7308/#comment25671>

    getInetSocketAddress -> resolveAddress



src/main/java/org/apache/giraph/comm/netty/NettyWorkerClient.java
<https://reviews.apache.org/r/7308/#comment25672>

    getInetSocketAddress -> resolveAddress


- Avery Ching


On Sept. 29, 2012, 4:39 p.m., Avery Ching wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7308/
> -----------------------------------------------------------
> 
> (Updated Sept. 29, 2012, 4:39 p.m.)
> 
> 
> Review request for giraph.
> 
> 
> Description
> -------
> 
> Review of Eli's GIRAPH-328.5.patch.  Reviewboard helps me to be more precise about my
comments.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/giraph/comm/SendMessageCache.java 3d38712 
>   src/main/java/org/apache/giraph/comm/messages/SimpleMessageStore.java ce0e64c 
>   src/main/java/org/apache/giraph/comm/netty/NettyWorkerClient.java 126b18e 
>   src/main/java/org/apache/giraph/comm/requests/RequestType.java 4fbf692 
>   src/main/java/org/apache/giraph/comm/requests/SendPartitionCurrentMessagesRequest.java
7cae1e2 
>   src/main/java/org/apache/giraph/comm/requests/SendPartitionMessagesRequest.java 1b3a435

>   src/main/java/org/apache/giraph/comm/requests/SendWorkerMessagesRequest.java PRE-CREATION

>   src/main/java/org/apache/giraph/graph/BspServiceMaster.java 6edd31e 
>   src/main/java/org/apache/giraph/graph/WorkerInfo.java 0224d87 
>   src/test/java/org/apache/giraph/comm/RequestFailureTest.java 02f699f 
>   src/test/java/org/apache/giraph/comm/RequestTest.java aa0ddd2 
> 
> Diff: https://reviews.apache.org/r/7308/diff/
> 
> 
> Testing
> -------
> 
> mvn clean verify
> 
> 
> Thanks,
> 
> Avery Ching
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message