giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Avery Ching" <avery.ch...@gmail.com>
Subject Re: Review Request: GIRAPH-336
Date Thu, 27 Sep 2012 05:52:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7310/#review11965
-----------------------------------------------------------



http://svn.apache.org/repos/asf/giraph/trunk/giraph-formats-contrib/pom.xml
<https://reviews.apache.org/r/7310/#comment25507>

    Do we need this?  How did it build before?



http://svn.apache.org/repos/asf/giraph/trunk/giraph-formats-contrib/src/hcatalog/java/org/apache/giraph/format/hcatalog/HCatalogVertexInputFormat.java
<https://reviews.apache.org/r/7310/#comment25508>

    Would be nice to align these comments with the variable indent.  This happens a lot in
this code.



http://svn.apache.org/repos/asf/giraph/trunk/giraph-formats-contrib/src/hcatalog/java/org/apache/giraph/format/hcatalog/HCatalogVertexInputFormat.java
<https://reviews.apache.org/r/7310/#comment25509>

    shouldn't this be static (and capitalized)?



http://svn.apache.org/repos/asf/giraph/trunk/giraph-formats-contrib/src/hcatalog/java/org/apache/giraph/format/hcatalog/HCatalogVertexInputFormat.java
<https://reviews.apache.org/r/7310/#comment25516>

    These should be converted to using log4j, not just removed.



http://svn.apache.org/repos/asf/giraph/trunk/giraph-formats-contrib/src/hcatalog/java/org/apache/giraph/format/hcatalog/HCatalogVertexInputFormat.java
<https://reviews.apache.org/r/7310/#comment25510>

    Please keep with log4j



http://svn.apache.org/repos/asf/giraph/trunk/giraph-formats-contrib/src/hcatalog/java/org/apache/giraph/format/hcatalog/HiveGiraphRunner.java
<https://reviews.apache.org/r/7310/#comment25511>

    Convert to using logj4?



http://svn.apache.org/repos/asf/giraph/trunk/giraph-formats-contrib/src/main/java/org/apache/giraph/format/accumulo/AccumuloVertexInputFormat.java
<https://reviews.apache.org/r/7310/#comment25512>

    Why remove?



http://svn.apache.org/repos/asf/giraph/trunk/giraph-formats-contrib/src/main/java/org/apache/giraph/format/accumulo/AccumuloVertexInputFormat.java
<https://reviews.apache.org/r/7310/#comment25513>

    Why remove?



http://svn.apache.org/repos/asf/giraph/trunk/giraph-formats-contrib/src/main/java/org/apache/giraph/format/accumulo/AccumuloVertexOutputFormat.java
<https://reviews.apache.org/r/7310/#comment25514>

    Why remove?



http://svn.apache.org/repos/asf/giraph/trunk/giraph-formats-contrib/src/main/java/org/apache/giraph/format/accumulo/AccumuloVertexOutputFormat.java
<https://reviews.apache.org/r/7310/#comment25515>

    Why remove?


- Avery Ching


On Sept. 27, 2012, 5:52 a.m., Avery Ching wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7310/
> -----------------------------------------------------------
> 
> (Updated Sept. 27, 2012, 5:52 a.m.)
> 
> 
> Review request for giraph.
> 
> 
> Description
> -------
> 
> Review of GIRAPH-336.patch for Brian.
> 
> FYI, this fails to patch cleanly for me.
> 
> aching@achingmbp15:~/git/git_svn_giraph_trunk$ git status
> # On branch GIRAPH-328
> nothing to commit (working directory clean)
> aching@achingmbp15:~/git/git_svn_giraph_trunk$ patch -p0 < ~/Desktop/GIRAPH-336.patch

> patching file giraph-formats-contrib/src/hcatalog/java/org/apache/giraph/format/hcatalog/HiveGiraphRunner.java
> Hunk #1 FAILED at 45.
> 1 out of 1 hunk FAILED -- saving rejects to file giraph-formats-contrib/src/hcatalog/java/org/apache/giraph/format/hcatalog/HiveGiraphRunner.java.rej
> patching file giraph-formats-contrib/src/hcatalog/java/org/apache/giraph/format/hcatalog/HCatalogVertexInputFormat.java
> patching file giraph-formats-contrib/src/hcatalog/java/org/apache/giraph/format/hcatalog/HCatalogVertexOutputFormat.java
> patching file giraph-formats-contrib/src/main/java/org/apache/giraph/format/accumulo/AccumuloVertexInputFormat.java
> patching file giraph-formats-contrib/src/main/java/org/apache/giraph/format/accumulo/AccumuloVertexOutputFormat.java
> patching file giraph-formats-contrib/pom.xml
> 
> 
> Diffs
> -----
> 
>   http://svn.apache.org/repos/asf/giraph/trunk/giraph-formats-contrib/pom.xml 1389474

>   http://svn.apache.org/repos/asf/giraph/trunk/giraph-formats-contrib/src/hcatalog/java/org/apache/giraph/format/hcatalog/HCatalogVertexInputFormat.java
1389474 
>   http://svn.apache.org/repos/asf/giraph/trunk/giraph-formats-contrib/src/hcatalog/java/org/apache/giraph/format/hcatalog/HCatalogVertexOutputFormat.java
1389474 
>   http://svn.apache.org/repos/asf/giraph/trunk/giraph-formats-contrib/src/hcatalog/java/org/apache/giraph/format/hcatalog/HiveGiraphRunner.java
1389474 
>   http://svn.apache.org/repos/asf/giraph/trunk/giraph-formats-contrib/src/main/java/org/apache/giraph/format/accumulo/AccumuloVertexInputFormat.java
1389474 
>   http://svn.apache.org/repos/asf/giraph/trunk/giraph-formats-contrib/src/main/java/org/apache/giraph/format/accumulo/AccumuloVertexOutputFormat.java
1389474 
> 
> Diff: https://reviews.apache.org/r/7310/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Avery Ching
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message