giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alessandro Presta (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GIRAPH-294) Make LocalityInfoSorter a package private class
Date Mon, 17 Sep 2012 09:17:08 GMT

    [ https://issues.apache.org/jira/browse/GIRAPH-294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13456897#comment-13456897
] 

Alessandro Presta commented on GIRAPH-294:
------------------------------------------

I understand making it package private, but why remove the test? Maybe you want to take it
out of TestBspBasic and make it standalone?

                
> Make LocalityInfoSorter a package private class
> -----------------------------------------------
>
>                 Key: GIRAPH-294
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-294
>             Project: Giraph
>          Issue Type: Improvement
>            Reporter: Jakob Homan
>            Priority: Minor
>              Labels: newbie
>         Attachments: GIRAPH-294.patch
>
>
> There's no need for LocalityInfoSorter to be public.  It will be quite happy as package
private and shrink the visible footprint of the package.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message