giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brian Femiano (JIRA)" <>
Subject [jira] [Commented] (GIRAPH-349) Giraph Formats Tests broken
Date Thu, 27 Sep 2012 15:12:07 GMT


Brian Femiano commented on GIRAPH-349:

I fixed this temporarily in my patch for Giraph-336 by adding the same {forHadoop} property
in formats that mirrors the
main giraph pom. 

The issue is that this is technically not a child project to the giraph main pom, and thus
can't directly inherit it's properties.  

Having a base parent-pom in the trunk would probably solve this. 

> Giraph Formats Tests broken
> ---------------------------
>                 Key: GIRAPH-349
>                 URL:
>             Project: Giraph
>          Issue Type: Bug
>            Reporter: Nitay Joffe
>            Assignee: Eli Reisman
> GIRAPH-209 broke giraph-formats-contrib tests because of the prop.jarLocation change.
> In giraph-formats-contrib/pom.xml we have prop.jarLocation set as:
>                         <property>
>                             <name>prop.jarLocation</name>
>                             <value>${giraph.trunk.base}/target/giraph-${project.version}-jar-with-dependencies.jar</value>
>                         </property>
> The problem is I don't see how to easily get the hadoop version (until maybe we have
the parent pom which can hold the version for everyone to use). Eli, assigning this to you
for your thoughts.
> Note that when I changed this value by hand to ${giraph.trunk.base}/target/giraph-${project.version}-for-hadoop-
the tests run. Something is still failing but it is a completely different reason, not because
of System.getProperty("prop.jarLocation") problems.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

View raw message