Mailing-List: contact dev-help@giraph.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@giraph.apache.org
Date: Sat, 18 Aug 2012 10:20:38 +1100 (NCT)
From: "Eli Reisman (JIRA)" <jira@apache.org>
To: giraph-dev@incubator.apache.org
Message-ID: <1939195238.25612.1345245638128.JavaMail.jiratomcat@arcas>
In-Reply-To: <1532242292.22789.1345191278051.JavaMail.jiratomcat@arcas>
Subject: [jira] [Commented] (GIRAPH-302) Thread safety issue with sending
 partitions around
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/GIRAPH-302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13437135#comment-13437135 ] 

Eli Reisman commented on GIRAPH-302:
------------------------------------

Excellent! Right there under our noses the whole time...

                
> Thread safety issue with sending partitions around
> --------------------------------------------------
>
>                 Key: GIRAPH-302
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-302
>             Project: Giraph
>          Issue Type: Bug
>            Reporter: Avery Ching
>            Assignee: Avery Ching
>            Priority: Critical
>         Attachments: GIRAPH-302.patch
>
>
> When calling sendPartitionRequest(), we clear the vertex list afterward, making it a race!
> I noticed this when I was running with 300 workers and the number of edges wasn't what I expected.  Sometimes we get empty requests!
> After digging into the code I found the issue and have fixed it.
> Giraph Stats   Aggregate edges   99,971,220              0      99,971,220
> Superstep      11        0       11
> Current workers          300     0      300
> Last checkpointed superstep      0      0       0
> Current master task partition    0      0       0
> Sent messages  0    0            0
> Aggregate finished vertices      10,000,000     0       10,000,000
> Aggregate vertices               10,000,000     0       10,000,000
> This is wrong!
> Giraph Stats    Aggregate edges         100,000,000     0       100,000,000
> Superstep       11        0             11
> Last checkpointed superstep             0       0       0
> Current workers   300                   0       300
> Current master task partition           0       0       0
> Sent messages  0    0                   0
> Aggregate finished vertices             10,000,000      0       10,000,000
> Aggregate vertices                      10,000,000      0       10,000,000
> Fixed!

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira