Return-Path: X-Original-To: apmail-giraph-dev-archive@www.apache.org Delivered-To: apmail-giraph-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E4C12DB45 for ; Fri, 17 Aug 2012 08:14:49 +0000 (UTC) Received: (qmail 84957 invoked by uid 500); 17 Aug 2012 08:14:49 -0000 Delivered-To: apmail-giraph-dev-archive@giraph.apache.org Received: (qmail 84387 invoked by uid 500); 17 Aug 2012 08:14:42 -0000 Mailing-List: contact dev-help@giraph.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@giraph.apache.org Delivered-To: mailing list dev@giraph.apache.org Received: (qmail 84299 invoked by uid 500); 17 Aug 2012 08:14:39 -0000 Delivered-To: apmail-incubator-giraph-dev@incubator.apache.org Received: (qmail 84267 invoked by uid 99); 17 Aug 2012 08:14:38 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 17 Aug 2012 08:14:38 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 0C54A2C5BE6 for ; Fri, 17 Aug 2012 08:14:38 +0000 (UTC) Date: Fri, 17 Aug 2012 19:14:38 +1100 (NCT) From: "Avery Ching (JIRA)" To: giraph-dev@incubator.apache.org Message-ID: <1532242292.22789.1345191278051.JavaMail.jiratomcat@arcas> Subject: [jira] [Created] (GIRAPH-302) Thread safety issue with sending partitions around MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 Avery Ching created GIRAPH-302: ---------------------------------- Summary: Thread safety issue with sending partitions around Key: GIRAPH-302 URL: https://issues.apache.org/jira/browse/GIRAPH-302 Project: Giraph Issue Type: Bug Environment: When calling sendPartitionRequest(), we clear the vertex list afterward, making it a race! I noticed this when I was running with 300 workers and the number of edges wasn't what I expected. Sometimes we get empty requests! After digging into the code I found the issue and have fixed it. Giraph Stats Aggregate edges 99,971,220 0 99,971,220 Superstep 11 0 11 Current workers 300 0 300 Last checkpointed superstep 0 0 0 Current master task partition 0 0 0 Sent messages 0 0 0 Aggregate finished vertices 10,000,000 0 10,000,000 Aggregate vertices 10,000,000 0 10,000,000 This is wrong! Giraph Stats Aggregate edges 100,000,000 0 100,000,000 Superstep 11 0 11 Last checkpointed superstep 0 0 0 Current workers 300 0 300 Current master task partition 0 0 0 Sent messages 0 0 0 Aggregate finished vertices 10,000,000 0 10,000,000 Aggregate vertices 10,000,000 0 10,000,000 Fixed! Reporter: Avery Ching Assignee: Avery Ching Priority: Critical -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira