giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maja Kabiljo (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GIRAPH-259) TestBspBasic.testBspPageRank is broken
Date Sat, 04 Aug 2012 19:42:02 GMT

    [ https://issues.apache.org/jira/browse/GIRAPH-259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13428666#comment-13428666
] 

Maja Kabiljo commented on GIRAPH-259:
-------------------------------------

Eli, as for the change 31 -> 32 (TestBspBasic, lines 418-420), that test checks how many
times each aggregator value was written to AggregatorWriter. Before this patch, in this test
aggregators were not registered on master, they were registered only in WorkerContext, so
in master superstep 0 master didn't have the aggregators so didn't write them then. Removing
the need for aggregators to be registered on worker, I register aggregators in MasterCompute
so now they are written to AggregatorWriter even in superstep 0. That's why I had to make
this change. But are you sure you are getting that mistake, and not the "wrong value of SumAggreg:
30, should be: 15"? Because those checks come first in the test, and they don't work without
this patch. I tried to run tests with your patch on GIRAPH-218 and I do get this sum error.

Avery, I'll remove json then, since we are going to move aggregators away from zookeeper anyway.
                
> TestBspBasic.testBspPageRank is broken
> --------------------------------------
>
>                 Key: GIRAPH-259
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-259
>             Project: Giraph
>          Issue Type: Bug
>            Reporter: Maja Kabiljo
>            Assignee: Maja Kabiljo
>         Attachments: GIRAPH-259-1.patch, GIRAPH-259-2.patch, GIRAPH-259-3.patch, GIRAPH-259-4.patch
>
>
> Test crashes on line 152 in class SimplePageRankVertex in distributed mode.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message