giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hyunsik Choi (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GIRAPH-316) Add test-patch.sh for precommit test using Jenkins
Date Thu, 30 Aug 2012 16:06:08 GMT

    [ https://issues.apache.org/jira/browse/GIRAPH-316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13445052#comment-13445052
] 

Hyunsik Choi commented on GIRAPH-316:
-------------------------------------

Thank you for your comment.

Yes, I'll fix the jira path after this patch is committed. test-patch.sh can be executed in
your local machine. To run it, you may need findbugs (http://findbugs.sourceforge.net/). Type
a command as follows:

{code}
./dev-support/test-patch.sh --patch-dir=/tmp/patchprocess --findbugs-home=${FINDBUGS_HOME}
--run-tests ../GIRAPH-XXX.patch
{code}

Then, you will see the results of the patch verification, the check of javac/javadoc/findbugs/checkstyle
warnings, and unit tests.

Later, this script 'test-patch.sh' will automatically executed on Jenkins when a contributor
or committer submits a patch to jira. Like now, the PostCommit build (https://builds.apache.org/job/Giraph-trunk-Commit/)
will be launched after commit.
                
> Add test-patch.sh for precommit test using Jenkins
> --------------------------------------------------
>
>                 Key: GIRAPH-316
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-316
>             Project: Giraph
>          Issue Type: Sub-task
>          Components: test
>            Reporter: Hyunsik Choi
>            Assignee: Hyunsik Choi
>         Attachments: GIRAPH-316_2.patch, GIRAPH-316.patch
>
>
> For automatic pre-commit tests by jenkins, we need a script for downloading the recent
patch, compiling the patched source, and checking warnings. This patch includes the script.
I borrowed test-patch.sh from Hadoop, and I modified the following things:
> * Hadoop's test-patch does not allow any javadoc warnings, but this patch allows them
and does not allow the increase of javadoc warnings. This is because the current implementation
of Giraph already has 47 javadoc warnings.
> * Add the checkstyle check which is not implemented in Hadoop's one.
> * Add an options to take jira user as an argument.
> * Add some codes related to the project directory structure and some messages.
> * Changed some codes to reflect the target directory hierarchy caused by munged.
> You can check the integrated test from https://builds.apache.org/job/PreCommit-GIRAPH-Build/.
To execute the test, please click 'Build now' and type the number of Giraph jira issue. Now,
I gave the wrong path of the jira cli to jenkins because I don't want to disturb the jira.
So, you see "no such file/directory" error in "Adding comment to jira" section)
> After this patch is committed, I'll ask the automatic jenkins hook to builds@a.o as described
in http://wiki.apache.org/general/PreCommitBuilds.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message