giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maja Kabiljo (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GIRAPH-313) Open Netty client and server on master
Date Fri, 31 Aug 2012 13:19:07 GMT

    [ https://issues.apache.org/jira/browse/GIRAPH-313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13445914#comment-13445914
] 

Maja Kabiljo commented on GIRAPH-313:
-------------------------------------

I meant on rb that we use ReflectionUtils to climb the type hierarchy only for user defined
classes.

This piece of code previously was:

    WritableRequest<I, V, E, M> writableRequest = ReflectionUtils.newInstance(writableRequestClass,
conf);

but ReflectionUtils.newInstance doesn't really take generics into account, so this causes
unchecked conversion warning anyway. And it's not that now we are using raw type variable,
but the signature of WritableRequest class is changed, i.e. it's not parametrized anymore.

I guess you wanted to assign some other issue to yourself but reassigned this one by mistake?
:-)
                
> Open Netty client and server on master
> --------------------------------------
>
>                 Key: GIRAPH-313
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-313
>             Project: Giraph
>          Issue Type: Improvement
>            Reporter: Maja Kabiljo
>            Assignee: Eli Reisman
>         Attachments: GIRAPH-313.patch
>
>
> For GIRAPH-273 first thing we need is to open Netty communication on master, make connections
to workers and make connections from workers to master.
> Since it's already significant amount of code I'm opening a separate issue for it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message