giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eli Reisman (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GIRAPH-291) PredicateLock should have a constructor to take in a custom waiting time and additional testing
Date Wed, 08 Aug 2012 06:54:10 GMT

    [ https://issues.apache.org/jira/browse/GIRAPH-291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13430912#comment-13430912
] 

Eli Reisman commented on GIRAPH-291:
------------------------------------

Changing waitForever to boolean is so it could be tested/verified that the call returns and
the event goes through. This is why someone had the hack in the test of calling waitMsecs(-1)
directly rather than testing waitForever() it doesn't happen anywhere else outside the tests.

                
> PredicateLock should have a constructor to take in a custom waiting time and additional
testing
> -----------------------------------------------------------------------------------------------
>
>                 Key: GIRAPH-291
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-291
>             Project: Giraph
>          Issue Type: Improvement
>            Reporter: Avery Ching
>            Assignee: Avery Ching
>         Attachments: GIRAPH-291.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message