giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eugene Koontz" <ekoo...@hiro-tan.org>
Subject Re: Review Request: GIRAPH-211: Add secure authentication to Netty IPC
Date Thu, 30 Aug 2012 01:50:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6609/
-----------------------------------------------------------

(Updated Aug. 30, 2012, 1:50 a.m.)


Review request for giraph.


Changes
-------

Correct URL to patch in JIRA.


Description (updated)
-------

Same patch as: https://issues.apache.org/jira/secure/attachment/12543007/GIRAPH-211.patch

Current limitations:

-Not tested on other than hadoop 2.0.1-SNAPSHOT
-Needs useAuth=true switch to turn on/off (default = off(?))

How to compile and test:

mvn -Phadoop_2.0.1 clean test

Works with the following test:

$HADOOP_RUNTIME/bin/hadoop jar $GIRAPH_DIR/target/giraph-0.2-SNAPSHOT-for-hadoop-2.0.1-SNAPSHOT-jar-with-dependencies.jar
org.apache.giraph.benchmark.PageRankBenchmark -Dgiraph.useNetty=true -e 2 -s 10 -v -V 2 -w
2


This addresses bug GIRAPH-211.
    https://issues.apache.org/jira/browse/GIRAPH-211


Diffs
-----

  src/main/java/org/apache/giraph/comm/BasicRPCCommunications.java bc53b83 
  src/main/java/org/apache/giraph/comm/ServerData.java 68a2044 
  src/main/java/org/apache/giraph/comm/WorkerClient.java c3ec4fe 
  src/main/java/org/apache/giraph/comm/netty/NettyClient.java 428b877 
  src/main/java/org/apache/giraph/comm/netty/NettyServer.java 5904908 
  src/main/java/org/apache/giraph/comm/netty/NettyWorkerClient.java 72e79a9 
  src/main/java/org/apache/giraph/comm/netty/NettyWorkerClientServer.java b06e0f6 
  src/main/java/org/apache/giraph/comm/netty/SaslNettyClient.java PRE-CREATION 
  src/main/java/org/apache/giraph/comm/netty/SaslNettyServer.java PRE-CREATION 
  src/main/java/org/apache/giraph/comm/netty/handler/MasterRequestServerHandler.java 719515d

  src/main/java/org/apache/giraph/comm/netty/handler/RequestServerHandler.java 6f0fc20 
  src/main/java/org/apache/giraph/comm/netty/handler/ResponseClientHandler.java c1c2574 
  src/main/java/org/apache/giraph/comm/netty/handler/WorkerRequestServerHandler.java e8b6c54

  src/main/java/org/apache/giraph/comm/requests/NullReply.java PRE-CREATION 
  src/main/java/org/apache/giraph/comm/requests/RequestType.java 4fbf692 
  src/main/java/org/apache/giraph/comm/requests/ResponseEncoder.java PRE-CREATION 
  src/main/java/org/apache/giraph/comm/requests/SaslComplete.java PRE-CREATION 
  src/main/java/org/apache/giraph/comm/requests/SaslTokenMessage.java PRE-CREATION 
  src/main/java/org/apache/giraph/comm/requests/SendPartitionCurrentMessagesRequest.java 7cae1e2

  src/main/java/org/apache/giraph/comm/requests/SendPartitionMessagesRequest.java 6c7ebb6

  src/main/java/org/apache/giraph/comm/requests/SendPartitionMutationsRequest.java d3553c1

  src/main/java/org/apache/giraph/comm/requests/SendVertexRequest.java 2004db4 
  src/main/java/org/apache/giraph/comm/requests/WritableRequest.java a68b26a 

Diff: https://reviews.apache.org/r/6609/diff/


Testing
-------

Tested only on Hadoop 2.0.1-SNAPSHOT : needs testing on other Hadoops.


Thanks,

Eugene Koontz


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message