giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eugene Koontz" <ekoo...@hiro-tan.org>
Subject Re: Review Request: GIRAPH-211: Add secure authentication to Netty IPC
Date Wed, 29 Aug 2012 18:46:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6609/
-----------------------------------------------------------

(Updated Aug. 29, 2012, 6:46 p.m.)


Review request for giraph.


Changes
-------

Updated to correspond to https://issues.apache.org/jira/secure/attachment/12542963/GIRAPH-211.patch


Description (updated)
-------

Same patch as: https://issues.apache.org/jira/secure/attachment/12542963/GIRAPH-211.patch

Current limitations:

-Not tested on other than hadoop 2.0.1-SNAPSHOT
-Needs useAuth=true switch to turn on/off (default = off(?))

How to compile and test:

mvn -Phadoop_2.0.1 clean test

Works with the following test:

$HADOOP_RUNTIME/bin/hadoop jar $GIRAPH_DIR/target/giraph-0.2-SNAPSHOT-for-hadoop-2.0.1-SNAPSHOT-jar-with-dependencies.jar
org.apache.giraph.benchmark.PageRankBenchmark -Dgiraph.useNetty=true -e 2 -s 10 -v -V 2 -w
2


This addresses bug GIRAPH-211.
    https://issues.apache.org/jira/browse/GIRAPH-211


Diffs
-----

  src/main/java/org/apache/giraph/comm/BasicRPCCommunications.java bc53b83 
  src/main/java/org/apache/giraph/comm/MasterRequestServerHandler.java 16e163a 
  src/main/java/org/apache/giraph/comm/NettyClient.java 0353924 
  src/main/java/org/apache/giraph/comm/NettyServer.java 44a0043 
  src/main/java/org/apache/giraph/comm/NettyWorkerClient.java e5822e1 
  src/main/java/org/apache/giraph/comm/NettyWorkerClientServer.java 139e6f0 
  src/main/java/org/apache/giraph/comm/RequestServerHandler.java eae3f87 
  src/main/java/org/apache/giraph/comm/RequestType.java e363ad8 
  src/main/java/org/apache/giraph/comm/ResponseClientHandler.java 3adee8d 
  src/main/java/org/apache/giraph/comm/SendPartitionMessagesRequest.java 4944894 
  src/main/java/org/apache/giraph/comm/SendPartitionMutationsRequest.java c39ba60 
  src/main/java/org/apache/giraph/comm/SendVertexRequest.java 014043d 
  src/main/java/org/apache/giraph/comm/ServerData.java 68a2044 
  src/main/java/org/apache/giraph/comm/WorkerClient.java c3ec4fe 
  src/main/java/org/apache/giraph/comm/WorkerRequestServerHandler.java ee4e286 
  src/main/java/org/apache/giraph/comm/WritableRequest.java 931feb7 
  src/main/java/org/apache/giraph/comm/messages/SendPartitionCurrentMessagesRequest.java b10e6e9


Diff: https://reviews.apache.org/r/6609/diff/


Testing
-------

Tested only on Hadoop 2.0.1-SNAPSHOT : needs testing on other Hadoops.


Thanks,

Eugene Koontz


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message