giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gianmarco De Francisci Morales" <g...@apache.org>
Subject Review Request: SequenceFile output format (id-value only)
Date Mon, 13 Aug 2012 11:22:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6569/
-----------------------------------------------------------

Review request for giraph and Jakob Homan.


Description
-------

GIRAPH-235: SequenceFile output format (id-value only)

Had to fiddle a bit with the patch format for git-rb incompatibility, hope it is still good.


This addresses bug GIRAPH-235.
    https://issues.apache.org/jira/browse/GIRAPH-235


Diffs
-----

  /src/main/java/org/apache/giraph/io/SequenceFileIdValueOutputFormat.java PRE-CREATION 
  /src/main/java/org/apache/giraph/io/SequenceFileVertexIdValueOutputFormat.java PRE-CREATION


Diff: https://reviews.apache.org/r/6569/diff/


Testing
-------

Passes mvn verify, apart from findbugs, but it is unrelated to this patch.

[INFO] --- findbugs-maven-plugin:2.5.1:check (default) @ giraph ---
[INFO] BugInstance size is 2
[INFO] Error size is 0
[INFO] Total bugs: 2
[INFO] org.apache.giraph.BspCase.getNumResults(Configuration, Path) discards result of readLine
after checking if it is nonnull ["org.apache.giraph.BspCase"] At BspCase.java:[lines 44-394]
[INFO] Dead store to env in org.apache.giraph.examples.SimpleTriangleClosingVertexTest.testSuperstepOne()
["org.apache.giraph.examples.SimpleTriangleClosingVertexTest"] At SimpleTriangleClosingVertexTest.java:[lines
36-94]


Thanks,

Gianmarco De Francisci Morales


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message